ngMobile's overridden ngClick directive fails to bust the click event

[davgothic]

I've already reported this issue 21 days ago, here: #3132 and unfortunately it got tacked onto the back of another issue which resulted in it being closed. So here we go again :)

Here is an example of the problem: http://embed.plnkr.co/HQvrYQ/preview

The problem is that the tap event might have caused the DOM to change, so that the click fires in the same position but something else is there now which causes the new DOM element to incorrectly receive the event.

This issue is noticeable on iOS Safari, inside an iOS UIWebView, Android Default Browser (not Chrome) and inside an Android WebView. This does not seem to be an issue with Chrome on Android.

[bshepherdson]

So this is exactly why clickbusting is hard. If the click always came down on the same element as the touchstart and touchend, it would be straightforward.

The ngMobile code for clickbusting works by attaching a global click handler to the document, during the early, bubble-down "capture" phase. It intercepts the click event very early in its life, and checks its coordinates -- not target element -- against the stored locations of previous clicks. If it's close enough (~25px) to a previous fast click, and within a second or so, it gets busted.

Chrome for Android has some handling to fix this stupidity around slow click events and just work, so perhaps it's not reproducing the issue fully? I don't have an iOS device handy for testing, since I'm traveling now. I'll see if I can track one down. If not, I can examine this issue in a couple of weeks when I'm back at my main office and have my team's testing devices again.