False boolean values found when using ng-show/ng-hide

[johnwun]

Re-opening this ticket from a year ago. This is clearly a bug in Angular, and should not have been closed.

If you type 'n', 'no', 'f', 'false' or '0' into the search field, ng-hide / ng-show is triggered incorrectly.

Here is an updated plunker illustrating the issue:
http://plnkr.co/U99tFB

Original ticket:
#1229

[tuuling]

I agree. The docs clearly say :"When the ngShow expression evaluates to false then the ng-hide CSS class is added to the class attribute on the element causing it to become hidden." There is no way that one would expect a string in some cases evaluates to true and in other cases to false.

[jgeorge-gc]

+1

I'd expect a string value to evaluate to true. The current behavior is very confusing and should be fixed or at least mentioned in the docs.

[jhartikainen]

It's rather non-standard behavior which could very easily cause bugs, so unless there's some actual reason for this, +1 for fix.

[caitp]

The documentation fix should inform users of this behaviour, however I think the toBoolean() stuff is probably going to be removed in the future, so a proper solution for your bug may be waiting... Feel free to re-open this issue if you don't find a documentation update satisfactory

[bytasv]

Oh.. this kind of magic is just pure evil.. Why would anyone do such a weird thing and introduce this kind of typecasting?
Simply changing function toBoolean(value) { ... } to:

function toBoolean(value) {
  return Boolean(value);
}

Would bring an expected behaviour.

[constfun]

This issue should be reopened.

As @bytasv has mentioned this is pure evil. This is clearly a bug, moreover it's a a bug that is very difficult to catch! Mentioning it in the docs is not a solution.

[caitp]

Dudes, calm down! I am in perfect agreement that it's not the right thing to do. Maybe some day we can remove toBoolean() from the tree entirely. It would be a breaking change, so if it's going to happen, it should happen before 1.3 goes stable.

PRs welcome, IMO.