Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

ng-include directives don't work inside ng-repeat (v1.2.0rc1) #3581

Closed
ernestoalejo opened this issue Aug 14, 2013 · 4 comments
Closed

ng-include directives don't work inside ng-repeat (v1.2.0rc1) #3581

ernestoalejo opened this issue Aug 14, 2013 · 4 comments

Comments

@ernestoalejo
Copy link

Old version (working):

http://jsfiddle.net/2Gqwg/76/

New version (not working):

http://jsfiddle.net/2Gqwg/77/

@hccampos
Copy link

+1

@DJCordhose
Copy link

Right, I can confirm this.

@XtraKrispi
Copy link

Same issue appears with ng-view inside a transcluded directive as well.

@mhevery
Copy link
Contributor

mhevery commented Aug 15, 2013

Closing as duplicate of #3584

@mhevery mhevery closed this as completed Aug 15, 2013
IgorMinar added a commit to IgorMinar/angular.js that referenced this issue Feb 20, 2015
…nkwrap.clean.json

Previously we would clean up npm-shrinkwarp.json file in order to achieve serialization
stability, which would then allow us to create human readable diffs that allow code reviews
of npm-shrinkwrap to be meaningful.

This cleanup process does have an impact on the functionality of npm which was only recently
discovered by Vojta, when we tried to update to new Karma version. See: socketio/engine.io-client#370

According to Julie, the root cause of these issues is npm/npm/angular#3581.

The workaround implemented in this commit is not to interfere with npm-shrinkwrap.json file, but instead
preserve the cleaned up version of its content in npm-shrinkwrap.clean.json which can then be used to
produce human readable diffs for code reviews of npm dependency updates.
IgorMinar added a commit that referenced this issue Feb 22, 2015
…nkwrap.clean.json

Previously we would clean up npm-shrinkwarp.json file in order to achieve serialization
stability, which would then allow us to create human readable diffs that allow code reviews
of npm-shrinkwrap to be meaningful.

This cleanup process does have an impact on the functionality of npm which was only recently
discovered by Vojta, when we tried to update to new Karma version. See: socketio/engine.io-client#370

According to Julie, the root cause of these issues is npm/npm/#3581.

The workaround implemented in this commit is not to interfere with npm-shrinkwrap.json file, but instead
preserve the cleaned up version of its content in npm-shrinkwrap.clean.json which can then be used to
produce human readable diffs for code reviews of npm dependency updates.
IgorMinar added a commit to IgorMinar/angular.js that referenced this issue Feb 22, 2015
…nkwrap.clean.json

Previously we would clean up npm-shrinkwarp.json file in order to achieve serialization
stability, which would then allow us to create human readable diffs that allow code reviews
of npm-shrinkwrap to be meaningful.

This cleanup process does have an impact on the functionality of npm which was only recently
discovered by Vojta, when we tried to update to new Karma version. See: socketio/engine.io-client#370

According to Julie, the root cause of these issues is npm/npm/angular#3581.

The workaround implemented in this commit is not to interfere with npm-shrinkwrap.json file, but instead
preserve the cleaned up version of its content in npm-shrinkwrap.clean.json which can then be used to
produce human readable diffs for code reviews of npm dependency updates.
netman92 pushed a commit to netman92/angular.js that referenced this issue Aug 8, 2015
…nkwrap.clean.json

Previously we would clean up npm-shrinkwarp.json file in order to achieve serialization
stability, which would then allow us to create human readable diffs that allow code reviews
of npm-shrinkwrap to be meaningful.

This cleanup process does have an impact on the functionality of npm which was only recently
discovered by Vojta, when we tried to update to new Karma version. See: socketio/engine.io-client#370

According to Julie, the root cause of these issues is npm/npm/angular#3581.

The workaround implemented in this commit is not to interfere with npm-shrinkwrap.json file, but instead
preserve the cleaned up version of its content in npm-shrinkwrap.clean.json which can then be used to
produce human readable diffs for code reviews of npm dependency updates.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants