Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Re-work $q a bit to better support decorators #3659

Closed
dcherman opened this issue Aug 19, 2013 · 1 comment
Closed

Re-work $q a bit to better support decorators #3659

dcherman opened this issue Aug 19, 2013 · 1 comment
Labels
component: $q frequency: high severity: inconvenient type: feature
Milestone
Backlog - won't fix

Comments

@dcherman
Copy link
Contributor

Currently, $q uses the defer() function in several places rather than referencing something like $q.defer()

This causes problems when you try to decorate promises because internally, $q is not calling the defer method that's defined/overriden in a decorator.

http://jsfiddle.net/3V2Xn/
@dcherman dcherman mentioned this issue Aug 20, 2013
Closed
@btford btford added this to the Backlog milestone Mar 27, 2014
@btford btford removed the gh: issue label Aug 20, 2014
@lgalfaso
Copy link
Contributor

lgalfaso commented Jan 2, 2015

With 1.3 $q uses prototypes for promises, so this is already possible

@lgalfaso lgalfaso closed this as completed Jan 2, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
component: $q frequency: high severity: inconvenient type: feature
Projects
None yet
Milestone
Backlog - won't fix
Development

Successfully merging a pull request may close this issue.

fix($q) allow $q to work well with decorators dcherman/angular.js
3 participants
@lgalfaso @btford @dcherman