This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
Return the same data to success as to $promise.then #3817
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you elaborate? A quick example of your desired usage would help us to suggest a better solution. |
|
Sure - here's a JSFiddle: http://jsfiddle.net/SH26x/1/ In that fiddle there are 4 example |
|
Your change breaks many tests and changes the behavior of $resource quite a lot. See my PR (#3823) for the correct fix. |
|
Lovely, thanks! |
btford
pushed a commit
to btford/angular.js
that referenced
this pull request
Oct 2, 2013
jankuca
added a commit
that referenced
this pull request
Oct 3, 2013
jamesdaily
pushed a commit
to jamesdaily/angular.js
that referenced
this pull request
Jan 27, 2014
jamesdaily
pushed a commit
to jamesdaily/angular.js
that referenced
this pull request
Jan 27, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feel free to reject if I've misunderstood this, but I was expecting my
success()callback to receive the same arguments as passed to$promise.then(). Currently the response interceptor gets bypassed when using thesuccess()approach.