This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix($resource): pass interceptor-transformed value to both success callbacks and promises #3823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/ngResource/resourceSpec.js
Outdated
There was a problem hiding this comment.
you can just write expect(a).toBe(b), but that is still a weak tests as both could be undefined and you wouldn't know it. a better test would be to to create var transformedValue = {a: 123}; and return that in the transformResponse fn. Then check that both a and b are transformedValue.
…llbacks and promises
ghost
assigned
|
Landed as e36e28e. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #3817
http://jsfiddle.net/SH26x/1/