bug(ngTransclude): breaking change in 1.2.0-rc.2

[bekos]

This commit (bf79bd4) seems to break things for async directives, that use transclude.

Here is a plunker: http://plnkr.co/edit/pp4zKjoBF6oY6DfoSkv2?p=preview

The problem is that inner directive cannot find the ngModelController on the outer directive, that uses ng-transclude.
This works fine with 1.2.0rc1 or if you replace the templateUrl with an inline template.

[petebacondarwin]

@bekos - can you try out @vojtajina's PR, #3927, as this may well help out here?

[bekos]

@petebacondarwin 👍 This PR works for my case :-) (Updated the plunker)

[petebacondarwin]

I am going to close this one then. Thanks

[pkozlowski-opensource]

@petebacondarwin are you sure that #3927 is going to be merged? @IgorMinar wasn't sounding too reassuring... In any case this introduces a breaking change on the angular-ui/bootstrap.

[petebacondarwin]

Something that fixes your issue will be merged. It may not be exactly
@vojta's change but it is clearly on the radar. If you want we can reopen
your issue for a while.

On 11 September 2013 13:20, Pawel Kozlowski notifications@github.comwrote:

@petebacondarwin https://github.com/petebacondarwin are you sure that
#3927 #3927 is going to be
merged? @IgorMinar https://github.com/IgorMinar wasn't sounding too
reassuring... In any case this introduces a breaking change on the
angular-ui/bootstrap.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/3923#issuecomment-24235441
.

[petebacondarwin]

@pkozlowski-opensource - what is the issue in bootstrap?

[bekos]

@petebacondarwin If I may help here, the flow that you see in the plunker is the same used in the datepicker-popup.

The datepicker-popup directive in an input $compiles something like <popup ng-model="date"><datepicker></datepicker></popup>. The popup template uses transclusion to place the datepikcer in the template and datepicker requires the ng-model from the popup.

The problem now (rc2) is that the datepicker cannot find the ngModelController.

[pkozlowski-opensource]

@petebacondarwin I would prefer that this one stays open till the fix is in master. I'm not sure if / when @vojtajina PR #3927 is going to be merged and this issue has nice reproduce scenario. I will monitor this issue and will close it as soon as a fix lands in master.