undefined TypeError: Cannot call method 'replace' of undefined in Android Browser

[playpianolikewoah]

In Android browser I use $location.path('/login'); to route. Example:

MainMenuCtrl.$inject = ['$scope', '$location'];
function MainMenuCtrl($scope, $location) {
    $scope.doFileWeeklyClaim = function() {
        $location.path('/login');
    };
};

When I navigate away to say google.com and press back when clicking on a link the routing becomes unavailable and I get this error from line 3268 from angular.js version 1.0.8:
undefined TypeError: Cannot call method 'replace' of undefined
Everything stops working at that point.

[petebacondarwin]

This is the line in question: https://github.com/angular/angular.js/blob/v1.0.x/src/ng/browser.js#L177

[petebacondarwin]

From this function, right near the bottom, location.href must be undefined.

self.url = function(url, replace) {
    // setter
    if (url) {
      if (lastBrowserUrl == url) return;
      lastBrowserUrl = url;
      if ($sniffer.history) {
        if (replace) history.replaceState(null, '', url);
        else {
          history.pushState(null, '', url);
          // Crazy Opera Bug: http://my.opera.com/community/forums/topic.dml?id=1185462
          baseElement.attr('href', baseElement.attr('href'));
        }
      } else {
        if (replace) {
          location.replace(url);
          replacedUrl = url;
        } else {
          location.href = url;
          replacedUrl = null;
        }
      }
      return self;
    // getter
    } else {
      // - the replacedUrl is a workaround for an IE8-9 issue with location.replace method that doesn't update
      //   location.href synchronously
      // - the replacement is a workaround for https://bugzilla.mozilla.org/show_bug.cgi?id=407172
      return replacedUrl || location.href.replace(/%27/g,"'");
    }
  };

[petebacondarwin]

Looks like android has some issues with $location. See #3814.
Can you confirm if this also happens with 1.2.0-rc.2?
Also, any chance you could provide a cut down running example of the problem to debug? Are you just accessing a web app or are you wrapping angular into a native app?

[playpianolikewoah]

This is from a webapp. Just accessing the app. When I switched out my current angular version with 1.2.0-rc.2 I got a bunch of errors so I'll make a new sample app to confirm with rc2. By tomorrow morning most likely.
I was wondering if this had anything to do with something like this:
http://stackoverflow.com/questions/15193359/does-android-support-window-location-replace-or-any-equivalent

[ajcrites]

Created test project that showcases issue: ajcrites/ng-loc-demo@8ab4b2b

Identical issue persists in latest Angular dev version: ajcrites/ng-loc-demo@01ff49f

Issue is related to bfcache. It seems the ng app will not work properly if the page is loaded from bfcache -- at least in some browsers.

Thanks to @tkayali

[tkayali]

@petebacondarwin We apologize for the delay in getting back to you. It's been a hectic week.

[jeffbcross]

Here's a simple plunkr reproducing the issue. http://plnkr.co/edit/OR7xH9QeCDsGpGpFOg9e

Clicking login, then visiting google.com, then going back will cause the error to be thrown in the Android browser.

[jeffbcross]

@ajcrites looks like BFCache is causing location to lose its reference to window.location. The issue is temporarily relieved by adding if (location !== window.location) location = window.location; inside of url(). I need to write some BFCache tests and figure the best approach to the problem.

[jeffbcross]

@ajcrites, @playpianolikewoah and @tkayali when you have a chance, could you test your app with this build? http://ci.angularjs.org/job/angular.js-jeff/66/artifact/build/angular.js