Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

jQuery migrate 1.1.0 shows warnings with angularjs 1.1.5 in various places #4107

Closed
danieljsinclair opened this issue Sep 22, 2013 · 4 comments
Closed

jQuery migrate 1.1.0 shows warnings with angularjs 1.1.5 in various places #4107

danieljsinclair opened this issue Sep 22, 2013 · 4 comments
Labels
PRs plz! type: chore
Milestone
1.2.x (old)

Comments

@danieljsinclair
Copy link

For example;

"jQuery.fn.attr('selected') may use property instead of attribute"
@petebacondarwin
Copy link
Contributor

A full list would be really helpful. A pull request with fixes would be even better!

@danieljsinclair
Copy link
Author

Sorry, I’ve only run into the one I listed in the description at present, but presumably anywhere else in the code that uses $.attr() would cause similar migration warnings.

From: Pete Bacon Darwin [mailto:notifications@github.com]
Sent: 22 September 2013 22:04
To: angular/angular.js
Cc: Daniel Sinclair
Subject: Re: [angular.js] jQuery migrate 1.1.0 shows warnings with angularjs 1.1.5 in various places (#4107)

A full list would be really helpful. A pull request with fixes would be even better!

—
Reply to this email directly or view it on GitHub #4107 (comment) .

colincasey added a commit to colincasey/angular.js that referenced this issue Sep 23, 2013
@colincasey
chore(select): fix migrate warning for jQuery.fn.attr('selected')
727d667 
Closes angular#4107
@colincasey colincasey mentioned this issue Sep 23, 2013
Closed
@colincasey
Copy link
Contributor

The jQuery.fn.attr('selected') warning was the only warning I could find in the codebase also. The full list of warnings detected by the migrate plugin can be found at https://github.com/jquery/jquery-migrate/blob/master/warnings.md

@petebacondarwin
Copy link
Contributor

Closing in favour of #4122

petebacondarwin pushed a commit to petebacondarwin/angular.js that referenced this issue Jun 14, 2014
@colincasey @petebacondarwin
chore(select): fix migrate warning for jQuery.fn.attr('selected')
523d0fc 
Closes angular#4107
petebacondarwin pushed a commit to petebacondarwin/angular.js that referenced this issue Jun 14, 2014
@colincasey @petebacondarwin
refact(select): use prop to modify the select property
24aee81 
jQuery suggests using `prop` rather than `attr` to modify the `select` property of an element.
You can see the full list of migration warnings for jQuery:
https://github.com/jquery/jquery-migrate/blob/master/warnings.md

Closes angular#4107
Closes angular#4122
petebacondarwin pushed a commit that referenced this issue Jun 14, 2014
@colincasey @petebacondarwin
refact(select): use prop to modify the select property
d7bfda6 
jQuery suggests using `prop` rather than `attr` to modify the `select` property of an element.
You can see the full list of migration warnings for jQuery:
https://github.com/jquery/jquery-migrate/blob/master/warnings.md

Closes #4107
Closes #4122
@mantisfilms mantisfilms mentioned this issue Jun 15, 2014
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
PRs plz! type: chore
Projects
None yet
Milestone
1.2.x (old)
Development

Successfully merging a pull request may close this issue.

chore(select): fix migrate warning for jQuery.fn.attr('selected') colincasey/angular.js
3 participants
@petebacondarwin @colincasey @danieljsinclair