ngAnimate causes serious layout thrashing

[mgol]

Using ngAnimate can cause serious layout thrashing. Compare two videos:

1. Our current app, ngAnimate included: http://youtu.be/kUf9vDYIlt0
2. Our current app with just one difference - removing ngAnimate from the list of modules our app depends on: http://youtu.be/210VHxidY0o

I recorded Timeline profiles for an operation of switching the tab from the second to the third one; version with ngAnimate causes a massive amount of reflows:

1. Timeline with ngAnimate included:
   
2. Timeline without ngAnimate:
   

One of my colleagues, @jrencz, created videos of analogous operations on his 4-year-old MacBook, notice the slowness:

1. ngAnimate included: http://www.youtube.com/watch?v=FEmSiWq1qAI
2. ngAnimate excluded: http://www.youtube.com/watch?v=bshDaxUAzU4

[joegaudet]

This is the same issue as #4011, but definitely would love to have it addressed.

[mgol]

@joegaudet Probably. My issue has more data, though. ;)

[joegaudet]

Yeah, we experience the same thing our app. We have tables of 400 + rows, which basically makes the app unusable. I put a guard in the animation code, but that ends up thrashing the filtering on repeaters.... so I guess waiting for @matsko et al.

[bfricka]

These looks like exact screen grabs of the timeline profiles for EPG app we're building right now.

[matsko]

The plan is to performance-tune ngAnimate using caching. Getting to work on this today and tomorrow actually.

[joegaudet]

@matsko sweet man, can't wait. Thanks as always for your hard work man.

[matsko]

My pleasure :)

[matsko]

@mzgol @joegaudet please try testing out your code using the JS files mentioned in #4011 (comment)

[mgol]

@matsko Is this available as a commit somewhere? I use a patched AngularJS version to add support for pushState (see #3325) so I need it as a commit and not just built files.

[matsko]

@mzgol matsko@1022d56

[mgol]

@matsko Unfortunately, after applying your patch there's still severe layout trashing with ngAnimate present in app dependencies; all those repaints disappear if the dependency is removed.

[matsko]

@mzgol merging something in so I'll be closing this issue soon.

[matsko]

Landed as ddcbf76

[mgol]

I confirm the issue is fixed on current master. Thanks again. Good work. :)

[bfricka]

Definitely. Congrats @matsko. 👍

[jeffbcross]

👍 👍 👍