ng-option should work when it contains newlines.

[jamie-pate]

It seems like we should be able to do this

<select ng-options="o.name as o.name
                    for o in model.options
                    | filter:{$hide:'!true'}"></select>

but it throws

Expected expression in form of '_select_ (as _label_)? for (_key_,)?_value_ in _collection_' but got 'o.name as o.name
                    for o in model.options
                    | filter:{$hide:'!true'}'.

I could prepare a pr if this seems like something that should be supported.
(Would I need to count \n as whitespace when parsing all expressions? Is this a larger issue with expressions in general? Are there any horrible horrible failure cases this would cause?)

[forivall]

Newlines are allowed in most places in the directive; they are just not allowed in the _collection_ part of the expression.

This

<select ng-options="o.name as o.name
                    for o in
                    model.options | filter:{$hide:'!true'}"></select>

works just fine.

Most expression regexes for directives contain plenty of \ss, so I don't think this is a larger issue.

[jamie-pate]

Hmm, good to know, I'd still expect whitespace to be whitespace though...
The issue just became much narrower and less important though :)

On Tue, Sep 24, 2013 at 11:34 AM, Jordan Klassen
notifications@github.comwrote:

Newlines are allowed in most places in the directive; they are just not
allowed in the collection part of the expression.

This

works just fine.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/4142#issuecomment-25030653
.

[petebacondarwin]

Feel free to send in a well crafted, CLA signed, PR for this!

[esarbanis]

I believe this is resolved with #5602, maybe you should close it.