Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Local fail on master on one of date filter tests #4218

Closed
mgol opened this issue Oct 2, 2013 · 6 comments
Closed

Local fail on master on one of date filter tests #4218

mgol opened this issue Oct 2, 2013 · 6 comments
Assignees
Milestone

Comments

@mgol
Copy link
Member

mgol commented Oct 2, 2013

Running grunt test on current master causes the following failure on my machine (a mid-2012 MacBook Pro with OS X 10.8.5):

Running "tests:jqlite" (tests) task
INFO [karma]: Karma v0.11.0 server started at http://localhost:9876/
INFO [launcher]: Starting browser Chrome
INFO [Chrome 30.0.1599 (Mac OS X 10.8.5)]: Connected on socket M-s8df8pw3pb7fBlwWjA
Chrome 30.0.1599 (Mac OS X 10.8.5): Executed 700 of 2289 SUCCESS (0 secs / 2.66 secs)
Chrome 30.0.1599 (Mac OS X 10.8.5): Executed 703 of 2289 SUCCESS (0 secs / 2.681 secs)
Chrome 30.0.1599 (Mac OS X 10.8.5): Executed 707 of 2289 SUCCESS (0 secs / 2.715 secs)
WARN [web-server]: 404: /%7B%7BtestUrl%7D%7D
Chrome 30.0.1599 (Mac OS X 10.8.5) filters date should accept negative numbers as strings FAILED
    Expected 'Jan 1, 1970' to equal 'Dec 31, 1969'.
    Error: Expected 'Jan 1, 1970' to equal 'Dec 31, 1969'.
        at null.<anonymous> (/Users/mgol/Documents/projects/public/angular.js/test/ng/filter/filtersSpec.js:250:26)
Chrome 30.0.1599 (Mac OS X 10.8.5): Executed 2289 of 2289 (1 FAILED) (9.315 secs / 8.54 secs)

The test apparently passes on angular-ci jobs since http://dashboard.angularjs.org doesn't show any errors.

What's wrong?

My locale, if that's relevant:

$ locale
LANG="en_US.UTF-8"
LC_COLLATE="en_US.UTF-8"
LC_CTYPE="en_US.UTF-8"
LC_MESSAGES="en_US.UTF-8"
LC_MONETARY="en_US.UTF-8"
LC_NUMERIC="en_US.UTF-8"
LC_TIME="en_US.UTF-8"
LC_ALL="en_US.UTF-8"
@ghost ghost assigned btford Oct 3, 2013
@btford
Copy link
Contributor

btford commented Oct 3, 2013

This is likely my fault. Looks like the failing test depends on your timezone. What timezone are you in @mzgol?

@mgol
Copy link
Member Author

mgol commented Oct 3, 2013

@btford I'm in Poland so it's Central European Summer Time (UTC+02:00)

@IgorMinar
Copy link
Contributor

@btford yes. that test bad as it is timezone dependent. could we used TzDate instead?

@IgorMinar
Copy link
Contributor

or write a regexp that is more permissive...

btford added a commit to btford/angular.js that referenced this issue Oct 8, 2013
@btford btford closed this as completed in 1366556 Oct 9, 2013
@btford
Copy link
Contributor

btford commented Oct 9, 2013

Should be fixed in master now @mzgol. Let me know if you still run into the issue.

@mgol
Copy link
Member Author

mgol commented Oct 9, 2013

@btford It doesn't throw an error anymore, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants