This repository was archived by the owner on Apr 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 27.4k
Local fail on master on one of date filter tests #4218
Milestone
Comments
This is likely my fault. Looks like the failing test depends on your timezone. What timezone are you in @mzgol? |
@btford I'm in Poland so it's Central European Summer Time (UTC+02:00) |
@btford yes. that test bad as it is timezone dependent. could we used TzDate instead? |
or write a regexp that is more permissive... |
Should be fixed in master now @mzgol. Let me know if you still run into the issue. |
@btford It doesn't throw an error anymore, thanks! |
jamesdaily
pushed a commit
to jamesdaily/angular.js
that referenced
this issue
Jan 27, 2014
jamesdaily
pushed a commit
to jamesdaily/angular.js
that referenced
this issue
Jan 27, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Running
grunt test
on currentmaster
causes the following failure on my machine (a mid-2012 MacBook Pro with OS X 10.8.5):The test apparently passes on angular-ci jobs since http://dashboard.angularjs.org doesn't show any errors.
What's wrong?
My
locale
, if that's relevant:The text was updated successfully, but these errors were encountered: