fix(input): make ngList honor custom separators

[purcell]

Remove support for regexp separators, and correctly use custom separator when formatting values into the control.

Follows @IgorMinar's suggestions from #2561, as suggested by @petebacondarwin in #4008.

The existing "should allow custom separator" test was incomplete, since it did not check that the custom separator was used to format the values in the control.

Notes:

1. The behaviour is still not perfect, because when using a custom separator containing whitespace, e.g. " | ", the spaces should be rendered into the control. Even with my changes, this is not the case, because the attr.ngList value has already been trimmed prior to being passed to the directive. I have omitted the failing test for this case. How would we handle this?
2. The whitespace behaviour should arguably be affected by the value of ng-trim where present: I'd suggest that when it is present, the values between the separators should not be trimmed.

[mary-poppins]

Thanks for the PR!

• Contributor signed CLA now or in the past
  • If you just signed, leave a comment here with your real name
• PR's commit messages follow the commit message format

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

[purcell]

I have previously signed a CLA, for #4207, but since that has apparently not been reviewed, I'll go ahead and sign another CLA. (Name: Stephen Purcell / Steve Purcell)

The mary-poppins bot doesn't seem to detect the valid commit message format, but I have the pre-commit hook installed locally and passing.

[IgorMinar]

LGTM, but since this requires a breaking change, I'm going to triage it for 1.3.x. It should be one of the first PRs to make it in.

thanks for all the work!

[tedjp]

Is there a way for this to split on newline for <textarea>s? I don't think "\n" works.

[hnordt]

+1

[petebacondarwin]

@tedjp - that is a good point. We should somehow support that without it becoming too complex

[petebacondarwin]

@tedjp - perhaps we could use 
?

[petebacondarwin]

Hmm http://plnkr.co/edit/rrMYTpzKUWEUtDKSYKGe?p=preview

[petebacondarwin]

OK, so to break on newlines we need to be able to get the whitespace from the ngList attribute.
This is possible using element.attr(attr.$attr.ngList).

Then we have the other question of whether to trim whitespace from the the list items. At the moment we always trim but if we are not going to trim the whitespace from the separator string then we might have a problem.

For instance, how should ng-list="|" and ng-list=" | " be treated both on splitting and joining? One could assume that for splitting a|b|c should be split the same by both into ['a', 'b', 'c'] but that when joining one would return a|b|c and the other a | b | c. Equally, a | b | c could be split into ['a', 'b', 'c'] or ['a ', ' b ', ' c'] depending on how we treat whitespace.

[petebacondarwin]

How about this?

If ngTrim is undefined or true (default):

• split the value using the trimmed ngList value
• trim the whitespace from each item after it has been split
• join the items back using the untrimmed ngList value

If ngTrim is false (user is taking control of the whitespace)

• split the value using the untrimmed ngList value
• do not trim whitespace from each item after it has been split
• join the items back using the untrimmed ngList value