fix for ngList: separator does not work - comma is used all the time #4008
Conversation
|
Thanks for the PR!
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
|
Related to #2561 |
|
In particular this comment from @IgorMinar:
|
|
@ptsurko - Perhaps you can update this PR to deal with those aspects too? Also the PR will need unit tests. |
Remove support for regexp separators, and correctly use custom separator when formatting values into the control. See angular#4008 and angular#2561.
|
I'm sorry, but I wasn't able to verify your CLA signature. CLA signature is required for any code contributions to AngularJS. Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match. If you signed the CLA as a corporation, please let me know the company's name. Thanks a bunch! PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR. |
|
Argh, I've signed it twice already, and definitely with the correct email address! But I'll give it another go now. :-) |
|
Okay, done. Steve Purcell, with the email I use for all my commits. |
|
(Did it via the click-through form for individuals.) |
|
Did the CLA signature show up this time? |
|
@IgorMinar Sorry, wrongly assumed these CLA comments were on #4344, which I submitted a couple of months ago as a more complete version of this PR, incorporating your feedback from #2561 and that of @petebacondarwin in #4008. |
The separator string used to split the view value into a list for the model value is now used to join the list items back together again for the view value. BREAKING CHANGE: The `ngList` directive no longer supports splitting the view value via a regular expression. We need to be able to re-join list items back together and doing this when you can split with regular expressions can lead to inconsistent behaviour and would be much more complex to support. If your application relies upon ngList splitting with a regular expression then you should either try to convert the separator to a simple string or you can implement your own version of this directive for you application. Closes angular#4008 Closes angular#2561 Closes angular#4344
The separator string used to split the view value into a list for the model value is now used to join the list items back together again for the view value. BREAKING CHANGE: The `ngList` directive no longer supports splitting the view value via a regular expression. We need to be able to re-join list items back together and doing this when you can split with regular expressions can lead to inconsistent behaviour and would be much more complex to support. If your application relies upon ngList splitting with a regular expression then you should either try to convert the separator to a simple string or you can implement your own version of this directive for you application. Closes angular#4008 Closes angular#2561 Closes angular#4344
The separator string used to split the view value into a list for the model value is now used to join the list items back together again for the view value. BREAKING CHANGE: The `ngList` directive no longer supports splitting the view value via a regular expression. We need to be able to re-join list items back together and doing this when you can split with regular expressions can lead to inconsistent behaviour and would be much more complex to support. If your application relies upon ngList splitting with a regular expression then you should either try to convert the separator to a simple string or you can implement your own version of this directive for you application. Closes #4008 Closes #2561 Closes #4344
ng-list="" does not work.
comma is hard-coded in formatters and is used all the time.