angular-loader Uncaught ReferenceError: minErr is not defined

[shahmirn]

We're using $script.js and angular-loader to async load our project and the introduction of minErr in 1.2.0-rc.3 is breaking.

http://plnkr.co/edit/rxxHSS0RZd6Xavsq5Njc?p=preview shows the error if you open up the console when running it.

[randallb]

Introduced by @petebacondarwin here:

https://github.com/angular/angular.js/blob/7a586e5c19f3d1ecc3fefef084ce992072ee7f60/src/loader.js

I think to fix, we could just remove the minErr reference or mock it. Not sure what the best approach is.

[kopa]

'assertNotHasOwnProperty' is not defined too ...

[gbruins]

I believe line #7 of angular-loader.js should be:

(function(window, angular, undefined) {'use strict';

Currently line #7 is just:
(

[RangerRick]

I'm seeing this as well in rc3.

[capaj]

It is also in 1.2.0

[klebba]

Still seeing this error in 1.2.0 bower dist

[petebacondarwin]

I'll look into this.

On 9 November 2013 23:48, Casey notifications@github.com wrote:

Still seeing this error in 1.2.0 bower dist

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/4437#issuecomment-28140032
.

[igorzg]

angular loader is not required if you load angular.js as your first dependency.
Because angular.module its part of angular.
http://plnkr.co/edit/T8MaIBGmKQokRezuyJx5?p=preview

But angular loader have bugs because its builded from src/loader wich requires minError and assertNotHasOwnProperty functions and $injectorMinErr which will trow an error if module dependency is not specified and module definition is not already defined.

https://github.com/angular/angular.js/blob/master/src/loader.js

[petebacondarwin]

I have submitted a PR that fixes this.