new isArrayLike is faulty

[ahoyahoy]

If I want to use something like this:

angular.extend(options, {
radius: 30,
length: 0
});

angular returns options = {};
because latest version isArrayLike returns true
new isArrayLike check only length property :/

[petebacondarwin]

This only happens if length is 0. If it is greater than zero then there is an extra check to see if the element, accessed by obj[obj.index-1], is also a member of the object.

[IgorMinar]

Do we need to special-case length=0 case?

[ahoyahoy]

Ahoj :)
some plugins use length=0 for setting
http://fgnass.github.io/spin.js/#?lines=13&length=0&width=10&radius=30&corners=1.0&rotate=0&trail=60&speed=1.0&direction=1

[tecteun]

the

(length - 1) in obj

part of isArrayLike() is also breaking compatibility with the latest/all versions of HtmlUnit. (due to a bug in HtmlUnit).

This is case is easily fixed by patching angular.js, using a 'get' on obj instead of a 'has', :

obj[length - 1]

I guess isArrayLike() should be rewritten a bit ;)

[jackcviers]

Hey guys,

I am currently working on this one.

I think isArrayLike, from the current implementation, is supposed to identify enumerable objects. Is this assumption correct?

[petebacondarwin]

I think you are right @jackcviers

[jackcviers]

The problem is that changing it to that definition will break a lot of the
codebase.

I think that can be addressed but in any case adding the length >= 0
doesn't break it, but it doesn't solve the use case stated here. I will
continue investigation.

I have changed the element clause to use hasChildren since vanilla nodes
don't have a length property. No tests break.

I'm considering adding an exists check for the null object case as well,
though I think a feature request for a maybe would be a more useful way
to do it. Thoughts?

[jackcviers]

@ahoyahoy Can you try #4855 and let us know if it fixes your issue?