Animations: animation code is executed for Comment Nodes, throwing exceptions

[ZissisT]

Hello,

in angular-animate.js:

animateSetup() method and animateRun() method do not check if current node is an Element Node and try to apply styles there, throwing exceptions (no style attribute to set style property). This happens on Comment Nodes (e.g. nodes that were commented out by ng-if ). A fix was added in 1.2 for the same issue in cancelChildAnimations() but I guess it's needed in the other 2 methods as well (issue found in latest 1.2.1 version stable version)

The fix was

    var node = element[0];
    if(node.nodeType != ELEMENT_NODE) {
      return;
    }

in the beginning of every method

Zissis

[matsko]

There are a few other issues related to this and I'm planning on rewriting parts of ngAnimate to properly handle cases where comments are encountered. There's currently one big animation PR that will go into 1.2.2. After that I will get on this one :)

[matsko]

Fixed with:

https://s3.amazonaws.com/angularjs-dev/ng-animate-comment-nodes/build/angular.js
https://s3.amazonaws.com/angularjs-dev/ng-animate-comment-nodes/build/angular-animate.js
https://s3.amazonaws.com/angularjs-dev/ng-animate-comment-nodes/build/angular-route.js

You can expect this with AngularJS 1.2.4.

[ZissisT]

Thank you very much !

Zissis

[Pyppe]

Added a comment for commit: 958d3d5#commitcomment-4869962

I'm seeing exceptions due to node being undefined within the cancelChildAnimations function.

[matsko]

Herra @Pyppe, do you have an example of the code that was causing the issue? It may be a mixture of some directives that may be causing the bug. It would be better to see if there is a fix for the instead of patching $animate. Kiitos :)