You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
This bug fix eed299a is breaking some transclusion scenarios and does not seems to have a work around.
The bug author is removing any thing inside the transclusion container which is causing the problem. Basically, he was asking for an empty container for transclusion.
when the transluded content is being teleported to the translusion point, we should ensure that
the translusion point is empty before appending otherwise we end up with junk before the transcluded
content
ngTransclude was never meant to be able to append content. This is something that just happened to work because of its implementation details.
Soon, Angular will use the Shadow DOM to implement transclusion. When using the new Shadow DOM API, elements projected into <content> elements replace the existing content of the element. This change is important in aligning Angular with emerging web standards.
It's unfortunate that this breaks your directive, but there are several pragmatic approaches to fixing it. You can rewrite your directive to move the ngTransclude directive onto a different element and then fix up the CSS accordingly. You can manually do the transclusion, or create a directive with the append behavior as suggested here: eed299a#commitcomment-4685184
This bug fix eed299a is breaking some transclusion scenarios and does not seems to have a work around.
The bug author is removing any thing inside the transclusion container which is causing the problem. Basically, he was asking for an empty container for transclusion.
Here is an example I am trying to do with bootstrap add on items with form elements.
Plunker with Angular 1.0.7 which works http://plnkr.co/edit/QT51rM7HOweE6tdmblEM
Same example with Angular 1.2.1 which does not work
http://plnkr.co/edit/bQcj6gXwbK7YJe7bGqUa
The text was updated successfully, but these errors were encountered: