Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Header code duplicated between home page and docs #5151

Closed
appsforartists opened this issue Nov 26, 2013 · 2 comments
Closed

Header code duplicated between home page and docs #5151

appsforartists opened this issue Nov 26, 2013 · 2 comments

Comments

@appsforartists
Copy link
Contributor

Although the UI looks identical, the header nav is not being shared between the main page and the docs page. For instance, a retina logo was added to the docs in #2874, but http://angularjs.org still has the old logo.

Browsing through the repo on GitHub, it isn't clear where the home page source is being rendered from, but it clearly isn't using the same template as the docs. To prevent bugs like the above where a change on one page doesn't propagate to the other (creating an inconsistent experience), the nav code should be shared among both.

@IgorMinar
Copy link
Contributor

yeah, this sucks.

the home page is rendered from http://github.com/angular/angularjs.org which is now slightly out of sync from the template used in docs.

keeping the two in sync is not that easy because the code lives in two different repos. I suppose we could just create a bower module (a component directive) that would contain just the header and then import it into both apps, but that would then impact the rendering time, since the template expansion would happen only after angular bootstraps, which I fear is not going to be a good user experience.

@petebacondarwin
Copy link
Contributor

The long term aim would be probably to merge the home page app and docs app into a single app. This should be possible with bike-shed eventually, meaning that the homepage would just become a generated page.
Moving to bike-shed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants