ngModelWatch not triggering a second digest when it fires #5258
Description
When ngModelWatch gets called, it can potentially change the validity of the form control and update the respective controllers.
Code in the template could be potentially binding to these values such as doing {{myForm.$valid}}.
You can see the issue in this plunkr:
http://plnkr.co/edit/MC5NZ0AXlqA3XnNCVyzb?p=preview
The problem is that ever since this commit:
The watch no longer returns any value. So the current digest will never be marked as dirty even though the watch has performed actions that should require a second pass through the digest loop.
I think the fix is probably just returning the value we get from ngModelGet($scope). This will allow the digest to compare the previous value and mark itself as dirty if necessary.
Does anyone see a problem with this approach? If not I can submit a PR.