$http should coalesce calls to $apply

[kseamon]

Presently, $http calls $apply for every request response, even if they come in within milliseconds of each other. Using a short timeout (0ms, which in practice works out to 0-10ms) to $apply can reduce a lot of waste.

See example implementation here: https://github.com/kseamon/angular.js/compare/http-coalesce?expand=1

Using this code (Not ready for a pull request as it breaks tests and mocks, etc), I see the number of $apply calls in my app's startup drop from 40 to 16.

[IgorMinar]

@cmelion from HBO is also interested in a solution like this.

[kseamon]

The PR I'm working on introduces an $$applyAsync function to $rootScope. Calling it results in a timeout that will call apply. Repeated calls of it are coalesced into a single $apply.

For starters, I'm calling it from $http, $evalAsync, and $cookies.

[kseamon]

I'll probably have it use a 0ms timeout. Increasing it does result in fewer apply calls in practice, but in my app, there's not much value to going above 10ms. I'd be fine using that too, but at some point we're slowing things down more than speeding them up.

[timkindberg]

+1

[kadimisetty]

+1

[dtabuenc]

+1

[fwielstra]

+1

[cesarandreu]

+1

[pixelcort]

+1

[erwinmombay]

+1

[damien-quintal]

+1

[codef0rmer]

+1

[PatrickJS]

+1

[just-boris]

+1

[Fjandin]

+1

[timelf123]

+1

[MattWalker]

+1

[greglockwood]

+1

[IgorMinar]

@kseamon since this proposal was already approved for 1.3 you don't need to prefix it with $$ use $ in your PR instead.

[rynz]

+1

[isamulenko]

+1

[aroop]

+1

[jkerkhofs]

+1

[saydogan]

+1

[thebigredgeek]

I'm willing to tackle this, if we are okay going ahead with it @IgorMinar ?

[kseamon]

I've got a PR in progress that I have not had a chance to work on in a while.

If you want to start from scratch, make sure to cover these points:

Implement $applyAsync on $rootScope.

Make $http and $cookies use it.

Make sure that regular $apply calls flush the queue and cancel the timeout.

[abirmingham]

+1

[filso]

+1

[Narretz]

@kseamon You could also push the branch to Github, if it's usable for further work.

[timelf123]

ping @kseamon