Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Add ng-aria binding #5486

Closed
Downchuck opened this issue Dec 19, 2013 · 10 comments
Closed

Add ng-aria binding #5486

Downchuck opened this issue Dec 19, 2013 · 10 comments

Comments

@Downchuck
Copy link

ARIA is a firm W3C standard for rich internet applications. An ng-aria binding would both encourage app authors to use ARIA when suitable and make it easy. Because of the role of ARIA with UI, it is appropriate to have this as a core AngularJS directive.

Example: ng-aria="{expanded: isOpen}"

This would toggle the attribute aria-expanded to the string true/false on the element.

@caitp
Copy link
Contributor

caitp commented Dec 19, 2013

sounds like a use-case for #4269

But that sounds like it would make a great third party module

@albell
Copy link

albell commented Dec 20, 2013

+1

1 similar comment
@nosideeffects
Copy link
Contributor

+1

@pkozlowski-opensource
Copy link
Member

One thing we could (easily?) do, thought, is to toggle aria visible attributes inside ng-show / ng-hide.

@arbus
Copy link

arbus commented Mar 14, 2014

I have an implementation of this as a separate module that covers most of the common aria bindings here.

I can create a PR for this if there is an interest having aria bindings as part of the core.

@btford
Copy link
Contributor

btford commented Jun 20, 2014

I am interested in this.

@arbus
Copy link

arbus commented Jun 21, 2014

@btford, should this be something that is automatically hooked into directives like ngShow and ngHide and then configured or maybe developed as a separate module the way ngRoute and ngAnimate are?

@marcysutton
Copy link
Contributor

+3. one for me, and two for my homies.

@btford
Copy link
Contributor

btford commented Jul 24, 2014

@arbus Implementation-wise, I'm kind of torn.

  • I think anyone using Angular should have sane a11y by default.
  • I think modules should be separated, so someone who wants more fine-grained control over a11y can use their own implementation and not have the bytes for Angular's default sitting around.

I think we're better off having a separate repo/module for this so that ARIA support doesn't block the 1.3 release, and so that we can iterate on and release better ARIA support independently of Angular's release cycle. I do think this is important enough to be maintained by angular-core.

@Downchuck
Copy link
Author

JQuery-UI went the accessible by default route. It worked out well, but
jQuery did not pick up on adding a .aria() method helper, and I think in
the long run that's meant that most module developers are unaware of it.

-Charles

On Thursday, July 24, 2014, Brian Ford notifications@github.com wrote:

@arbus https://github.com/arbus Implementation-wise, I'm kind of torn.

  • I think anyone using Angular should have sane a11y by default.
  • I think modules should be separated, so someone who wants more
    fine-grained control over a11y can use their own implementation and not
    have the bytes for Angular's default sitting around.

I think we're better off having a separate repo/module for this so that
ARIA support doesn't block the 1.3 release, and so that we can iterate on
and release better ARIA support independently of Angular's release cycle. I
do think this is important enough to be maintained by angular-core.


Reply to this email directly or view it on GitHub
#5486 (comment).

arbus pushed a commit to arbus/angular.js that referenced this issue Jul 25, 2014
Adds various aria attributes to the built in directives.

Closes angular#5486 and angular#1600
arbus pushed a commit to arbus/angular.js that referenced this issue Jul 25, 2014
Adds various aria attributes to the built in directives.
This module currently hooks into ng-show/hide, input, textarea
button as a basic level of support for a11y. I am using this as a
base for adding more tags into the mix for form direction flow,
making ng-repeat updates atomic but the tags here are the most
basic ones.

Closes angular#5486 and angular#1600
arbus pushed a commit to arbus/angular.js that referenced this issue Jul 25, 2014
Adds various aria attributes to the built in directives.
This module currently hooks into ng-show/hide, input, textarea
button as a basic level of support for a11y. I am using this as a
base for adding more tags into the mix for form direction flow,
making ng-repeat updates atomic but the tags here are the most
basic ones.

Closes angular#5486 and angular#1600
arbus pushed a commit to arbus/angular.js that referenced this issue Aug 12, 2014
Adds various aria attributes to the built in directives.
This module currently hooks into ng-show/hide, input, textarea
button as a basic level of support for a11y. I am using this as a
base for adding more tags into the mix for form direction flow,
making ng-repeat updates atomic but the tags here are the most
basic ones.

Closes angular#5486 and angular#1600
@btford btford removed the gh: issue label Aug 20, 2014
arbus pushed a commit to arbus/angular.js that referenced this issue Aug 23, 2014
Adds various aria attributes to the built in directives.
This module currently hooks into ng-show/hide, input, textarea
button as a basic level of support for a11y. I am using this as a
base for adding more tags into the mix for form direction flow,
making ng-repeat updates atomic but the tags here are the most
basic ones.

Closes angular#5486 and angular#1600
arbus pushed a commit to arbus/angular.js that referenced this issue Aug 28, 2014
Adds various aria attributes to the built in directives.
This module currently hooks into ng-show/hide, input, textarea
button as a basic level of support for a11y. I am using this as a
base for adding more tags into the mix for form direction flow,
making ng-repeat updates atomic but the tags here are the most
basic ones.

Closes angular#5486 and angular#1600
arbus pushed a commit to arbus/angular.js that referenced this issue Aug 30, 2014
Adds various aria attributes to the built in directives.
This module currently hooks into ng-show/hide, input, textarea
button as a basic level of support for a11y. I am using this as a
base for adding more tags into the mix for form direction flow,
making ng-repeat updates atomic but the tags here are the most
basic ones.

Closes angular#5486 and angular#1600
arbus pushed a commit to arbus/angular.js that referenced this issue Sep 5, 2014
Adds various aria attributes to the built in directives.
This module currently hooks into ng-show/hide, input, textarea
button as a basic level of support for a11y. I am using this as a
base for adding more tags into the mix for form direction flow,
making ng-repeat updates atomic but the tags here are the most
basic ones.

Closes angular#5486 and angular#1600
arbus pushed a commit to arbus/angular.js that referenced this issue Sep 5, 2014
Adds various aria attributes to the built in directives.
This module currently hooks into ng-show/hide, input, textarea
button as a basic level of support for a11y. I am using this as a
base for adding more tags into the mix for form direction flow,
making ng-repeat updates atomic but the tags here are the most
basic ones.

Closes angular#5486 and angular#1600
arbus pushed a commit to arbus/angular.js that referenced this issue Sep 6, 2014
Adds various aria attributes to the built in directives.
This module currently hooks into ng-show/hide, input, textarea
button as a basic level of support for a11y. I am using this as a
base for adding more tags into the mix for form direction flow,
making ng-repeat updates atomic but the tags here are the most
basic ones.

Closes angular#5486 and angular#1600
arbus pushed a commit to arbus/angular.js that referenced this issue Sep 11, 2014
Adds various aria attributes to the built in directives.
This module currently hooks into ng-show/hide, input, textarea
button as a basic level of support for a11y. I am using this as a
base for adding more tags into the mix for form direction flow,
making ng-repeat updates atomic but the tags here are the most
basic ones.

Closes angular#5486 and angular#1600
arbus pushed a commit to arbus/angular.js that referenced this issue Sep 11, 2014
Adds various aria attributes to the built in directives.
This module currently hooks into ng-show/hide, input, textarea
button as a basic level of support for a11y. I am using this as a
base for adding more tags into the mix for form direction flow,
making ng-repeat updates atomic but the tags here are the most
basic ones.

Closes angular#5486 and angular#1600
btford pushed a commit to btford/angular.js that referenced this issue Sep 18, 2014
Adds various aria attributes to the built in directives.
This module currently hooks into ng-show/hide, input, textarea
button as a basic level of support for a11y. I am using this as a
base for adding more tags into the mix for form direction flow,
making ng-repeat updates atomic but the tags here are the most
basic ones.

Closes angular#5486 and angular#1600
btford pushed a commit to btford/angular.js that referenced this issue Sep 18, 2014
Adds various aria attributes to the built in directives.
This module currently hooks into ng-show/hide, input, textarea
button as a basic level of support for a11y. I am using this as a
base for adding more tags into the mix for form direction flow,
making ng-repeat updates atomic but the tags here are the most
basic ones.

Closes angular#5486 and angular#1600
btford pushed a commit to btford/angular.js that referenced this issue Sep 18, 2014
Adds various aria attributes to the built in directives.
This module currently hooks into ng-show/hide, input, textarea
button as a basic level of support for a11y. I am using this as a
base for adding more tags into the mix for form direction flow,
making ng-repeat updates atomic but the tags here are the most
basic ones.

Closes angular#5486 and angular#1600
btford pushed a commit to btford/angular.js that referenced this issue Sep 18, 2014
Adds various aria attributes to the built in directives.
This module currently hooks into ng-show/hide, input, textarea
button as a basic level of support for a11y. I am using this as a
base for adding more tags into the mix for form direction flow,
making ng-repeat updates atomic but the tags here are the most
basic ones.

Closes angular#5486 and angular#1600
@btford btford closed this as completed in d1434c9 Sep 18, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants