Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

improve <script type="text/ng-template"> docs #5671

Closed
drewpca opened this issue Jan 7, 2014 · 2 comments
Closed

improve <script type="text/ng-template"> docs #5671

drewpca opened this issue Jan 7, 2014 · 2 comments
Assignees
Milestone

Comments

@drewpca
Copy link

drewpca commented Jan 7, 2014

http://docs.angularjs.org/api/ng.directive:script is broken:

  • the demo is floating above the demo box
  • the displayed demo code is incomplete

It would also be nice if "$templateCache" was a link to http://docs.angularjs.org/api/ng.$templateCache , which has some good information.

The question I came to the page with was: how do I specify an in-page template for my directive? The answer is templateUrl: 'id_of_script_tag_here', which I found by outside examples and guessing. (I thought it would be template: 'id_of_script_tag_here'.)

@ghost ghost assigned btford Jan 7, 2014
gsklee pushed a commit to gsklee/angular.js that referenced this issue Jan 8, 2014
gsklee pushed a commit to gsklee/angular.js that referenced this issue Jan 8, 2014
gsklee pushed a commit to gsklee/angular.js that referenced this issue Jan 8, 2014
@gsklee
Copy link
Contributor

gsklee commented Jan 8, 2014

The PR added missing info to make the doc more complete. For the broken demo, it's caused by improper closing of the script tag which should be separately addressed (#5648).

gsklee pushed a commit to gsklee/angular.js that referenced this issue Jan 8, 2014
@IgorMinar IgorMinar reopened this Jan 8, 2014
@IgorMinar
Copy link
Contributor

the broken demo part of this issue is being traced at #5648

jamesdaily pushed a commit to jamesdaily/angular.js that referenced this issue Jan 27, 2014
jamesdaily pushed a commit to jamesdaily/angular.js that referenced this issue Jan 27, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants