Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

$interval: Function is Not Called if invokeApply is False #5902

Closed
minznerjosh opened this issue Jan 20, 2014 · 2 comments
Closed

$interval: Function is Not Called if invokeApply is False #5902

minznerjosh opened this issue Jan 20, 2014 · 2 comments
Labels
component: misc core frequency: moderate needs: breaking change type: bug
Milestone
1.3.x - superlumi...

Comments

@minznerjosh
Copy link

This is because the notify handler of a promise is used to call the provided function. $q is tied to the $digest cycle so the function never gets called without a $digest!

I'm guessing this is not the desired behavior?
minznerjosh added a commit to minznerjosh/angular.js that referenced this issue Jan 20, 2014
@minznerjosh
fix($interval): call fn even if invokeApply is false
5e52bb2 
Becasue calling the interval function relies on a promise notify
handler, the interval function would not get called without a
invokeApply being true. With this update, if invokeApply is false, the
function is called normally.

Closes angular#5902
@minznerjosh minznerjosh mentioned this issue Jan 20, 2014
Closed
@caitp
Copy link
Contributor

caitp commented Jun 27, 2014

Is this fixed by #7999? I think it is, based on my tests --- unless it was already fixed earlier.

@caitp
Copy link
Contributor

caitp commented Jun 27, 2014

Looks like this has already been fixed http://plnkr.co/edit/lrerPdzoSasJXMf92MCw?p=preview (the bug is that the notify() causes a digest despite invokeApply=false, which #7999 fixes)

@caitp caitp closed this as completed Jun 27, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
component: misc core frequency: moderate needs: breaking change type: bug
Projects
None yet
Milestone
1.3.x - superluminal-nudge
Development

Successfully merging a pull request may close this issue.

fix($interval): call fn even if invokeApply is false minznerjosh/angular.js
2 participants
@minznerjosh @caitp