This repository was archived by the owner on Apr 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 27.4k
ng-class does not play simple CSS transitions when ngAnimate is included #6019
Comments
This is a known issue with $animate and will be refactored and fixed in 1.2.11. The goal is to make $animate respect natural transitions as best as possible. |
Correction. It will be released with |
What is the status on this issue? 1.2.12 seems to be released, but the changelog does not mention this issue. |
Not fixed yet. Had to change the internals of $animate to allow for this to work. Working hard to get this for 1.2.13. |
matsko
added a commit
to matsko/angular.js
that referenced
this issue
Feb 14, 2014
BREAKING CHANGE ngClass and {{ class }} will call the setClass animation callback instead of addClass / removeClass when both a addClass/removeClass operation is being executed on the element during the animation. Please include the setClass animation callback as well as addClass and removeClass within your JS animations to work with ngClass and {{ class }} directives. Closes angular#6019
matsko
added a commit
to matsko/angular.js
that referenced
this issue
Feb 14, 2014
BREAKING CHANGE ngClass and {{ class }} will call the setClass animation callback instead of addClass / removeClass when both a addClass/removeClass operation is being executed on the element during the animation. Please include the setClass animation callback as well as addClass and removeClass within your JS animations to work with ngClass and {{ class }} directives. Closes angular#6019
IgorMinar
pushed a commit
to IgorMinar/angular.js
that referenced
this issue
Feb 14, 2014
BREAKING CHANGE ngClass and {{ class }} will call the setClass animation callback instead of addClass / removeClass when both a addClass/removeClass operation is being executed on the element during the animation. Please include the setClass animation callback as well as addClass and removeClass within your JS animations to work with ngClass and {{ class }} directives. Closes angular#6019
IgorMinar
pushed a commit
to IgorMinar/angular.js
that referenced
this issue
Feb 14, 2014
BREAKING CHANGE ngClass and {{ class }} will call the setClass animation callback instead of addClass / removeClass when both a addClass/removeClass operation is being executed on the element during the animation. Please include the setClass animation callback as well as addClass and removeClass within your JS animations to work with ngClass and {{ class }} directives. Closes angular#6019
khepin
pushed a commit
to khepin/angular.js
that referenced
this issue
Feb 19, 2014
BREAKING CHANGE: ngClass and {{ class }} will now call the `setClass` animation callback instead of addClass / removeClass when both a addClass/removeClass operation is being executed on the element during the animation. Please include the setClass animation callback as well as addClass and removeClass within your JS animations to work with ngClass and {{ class }} directives. Closes angular#6019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
When ngAnimate is listed as an app's dependency, very basic CSS transitions do not animate. Here's a quick, dead-simple repro: http://plnkr.co/gZiIkxw007m0STgTfm6R
Fiddling with the version numbers, it looks like the issue was introduced in v1.2.6.
The text was updated successfully, but these errors were encountered: