Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

ng-repeat-end not removed if ngAnimate is included #6403

Closed
dgreif opened this issue Feb 21, 2014 · 6 comments
Closed

ng-repeat-end not removed if ngAnimate is included #6403

dgreif opened this issue Feb 21, 2014 · 6 comments
Assignees
@matsko
Labels
component: $compile component: ngAnimate component: ngRepeat frequency: moderate severity: regression type: bug
Milestone
1.2.14

Comments

@dgreif
Copy link

dgreif commented Feb 21, 2014

If you include angular animate 1.2.13 in an app, elements after an ng-repeat-start are not removed after items are removed from the collection.

plunker

This issue also shows up if you include angular toaster so I'm not sure if the issue is in angular animate or angular itself. Angular animate 1.2.12 does not present the same issue.
@caitp
Copy link
Contributor

caitp commented Feb 21, 2014

Fantastic bug report. Care to find the specific commit which seems to have broken this? That would be helpful in finding a fix. I'm still a bit worn out from doing a bisect earlier in the week for a different problem, so I probably won't do that until monday.

@caitp caitp added this to the 1.2.14 milestone Feb 21, 2014
@Narretz
Copy link
Contributor

Narretz commented Feb 21, 2014

possibly related: #6395

@dgreif
Copy link
Author

dgreif commented Feb 21, 2014

Commit 4f84f6b seems to have caused the issue.

@matsko matsko self-assigned this Feb 24, 2014
matsko added a commit to matsko/angular.js that referenced this issue Feb 26, 2014
@matsko
fix($animate): ensure all comment nodes are removed during a leave an…
590accc 
…imation

Closes angular#6403
@matsko matsko mentioned this issue Feb 26, 2014
Closed
@matsko
Copy link
Contributor

matsko commented Feb 26, 2014

Fixed in PR: #6462

matsko added a commit to matsko/angular.js that referenced this issue Feb 26, 2014
@matsko
fix($animate): ensure all comment nodes are removed during a leave an…
5f5123f 
…imation

Closes angular#6403
@matsko matsko closed this as completed in f4f1f43 Feb 26, 2014
@matsko
Copy link
Contributor

matsko commented Feb 26, 2014

Fixed. Landed as f4f1f43

@matsko
Copy link
Contributor

matsko commented Feb 26, 2014

Expect this in 1.2.14.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@matsko matsko

Labels
component: $compile component: ngAnimate component: ngRepeat frequency: moderate severity: regression type: bug
Projects
None yet
Milestone
1.2.14
Development

Successfully merging a pull request may close this issue.

fix($animate): ensure all comment nodes are removed during a leave animation matsko/angular.js
4 participants
@matsko @Narretz @caitp @dgreif