Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

setClass should be broken up into addClass + removeClass JS animations #6463

Closed
matsko opened this issue Feb 26, 2014 · 0 comments
Closed

setClass should be broken up into addClass + removeClass JS animations #6463

matsko opened this issue Feb 26, 2014 · 0 comments
Assignees
Milestone

Comments

@matsko
Copy link
Contributor

matsko commented Feb 26, 2014

setClass is run when ngClass changes and both addClass and removeClass are run at the same time. This works fine, but it also requires a setClass animation to be defined within the JS animations.

This because annoying when you have to watch for CSS class changes within addClass, removeClass and setClass. Instead setClass should break down to addClass and removeClass if setClass is not defined on the animation.

@matsko matsko added this to the 1.2.14 milestone Feb 26, 2014
@matsko matsko self-assigned this Feb 26, 2014
matsko added a commit to matsko/angular.js that referenced this issue Feb 27, 2014
matsko added a commit to matsko/angular.js that referenced this issue Feb 27, 2014
matsko added a commit to matsko/angular.js that referenced this issue Feb 27, 2014
matsko added a commit to matsko/angular.js that referenced this issue Feb 28, 2014
@matsko matsko closed this as completed in 18c41af Feb 28, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant