$location.search does not remove query args when pass in an object

[wangshijun]

When the following code is used to remove query args from location url, it worked as expected:

$location.search('sid', null);
$location.search('time', null);
$location.search('sign', null);

But, the following code does not work as expected:

$location.search({
    sid: null,
    time: null,
    asign: null
});

Please correct if this is the correct behavior of $location.search

[vojtajina]

That's a bug, I think setting an object should behave the same as setting a single param.

It's this code:

angular.js/src/ng/location.js

Lines 412 to 436 in 3cf2da0

	search: function(search, paramValue) {
	switch (arguments.length) {
	case 0:
	return this.$$search;
	case 1:
	if (isString(search)) {
	this.$$search = parseKeyValue(search);
	} else if (isObject(search)) {
	this.$$search = search;
	} else {
	throw $locationMinErr('isrcharg',
	'The first argument of the `$location#search()` call must be a string or an object.');
	}
	break;
	default:
	if (isUndefined(paramValue) || paramValue === null) {
	delete this.$$search[search];
	} else {
	this.$$search[search] = paramValue;
	}
	}
	this.$$compose();
	return this;
	},

, we need to check the object for nulls/undefineds, the same way we do when setting a single property.

[SekibOmazic]

Commit f3f3c88 is more elegant but uses Object.keys() which is not supported by IE8. The commit b7a926d uses for..in and hasOwnProperty() which works for all browsers.