Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Using ng-true-value in conjunction with ng-required fails to pass value to model #6875

Closed
pixelsailor opened this issue Mar 27, 2014 · 3 comments
Closed

Using ng-true-value in conjunction with ng-required fails to pass value to model #6875

pixelsailor opened this issue Mar 27, 2014 · 3 comments
Labels
component: forms frequency: moderate severity: broken expected use type: bug

Comments

@pixelsailor
Copy link

Using a list of checkboxes (within ng-repeat) I've found that checking a checkbox won't get evaluated if both the ng-true-value and ng-required attributes are present. Removing one or the other will allow the model to update normally.

See Plunker
http://plnkr.co/edit/keCYcSjyZnaSJMpHP2UE?p=preview
@lgalfaso lgalfaso self-assigned this Mar 27, 2014
@lgalfaso
Copy link
Contributor

It looks like a real bug

lgalfaso added a commit to lgalfaso/angular.js that referenced this issue Mar 27, 2014
@lgalfaso
fix(input): Allow ng-true-value and ng-required on a checkbox
e28002b 
Put the input[checkbox] formatter and parser first in the $formatters
and $parsers queue so they are the first being called when formatting
and the last when parsing

Closes angular#6875
@lgalfaso lgalfaso mentioned this issue Mar 27, 2014
Closed
@lgalfaso lgalfaso removed their assignment Mar 27, 2014
@Narretz
Copy link
Contributor

Narretz commented Mar 27, 2014

#5164 seems to be the same issue ?
and a fix: #6065

@lgalfaso
Copy link
Contributor

Dup of #5164. Closing
Thanks @Narretz for pointing this out

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
component: forms frequency: moderate severity: broken expected use type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(input): Allow ng-true-value and ng-required on a checkbox lgalfaso/angular.js
3 participants
@lgalfaso @Narretz @pixelsailor