This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 27.5k
ngClass space-delimited class string not being applied correctly when ngAnimate enabled #6957
Comments
Looking into it. Thanks. |
matsko
added a commit
to matsko/angular.js
that referenced
this issue
Apr 3, 2014
…ation if skipped Closes angular#6957
PR is awating :) We should have this ready for tomorrow and it will go into |
Great, thanks for the quick response! |
matsko
added a commit
to matsko/angular.js
that referenced
this issue
Apr 4, 2014
…ation if skipped Closes angular#6957
@timkendrick this is fixed now and in master and the 1.2.x branch. Sorry for not making the Thanks for pointing out the bug. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
ngClass seems to have trouble figuring out which old classes to remove if the databinding expression evaluates to string of space-delimited class names with the following format:
"before-class [my-dynamic-class] after-class"
This problem only appears when 'ngAnimate' is listed as an app dependency (even if no animations are specified).
It appears this bug was introduced with 1.2.13 (the example works fine if you include AngularJS 1.2.12 instead).
Example here: http://jsfiddle.net/8zs4r/
(all the bullet points are meant to stay the same color as each other – try clicking the button repeatedly and see what happens)
The text was updated successfully, but these errors were encountered: