AngularJS config block causes unknown provider error if provider is added to module after the config block

[thebigredgeek]

This was discussed in IRC at around 1:30-2:00 PM pacific on 04/16/2014 with @caitp

Test case is here https://github.com/thebigredgeek/provider-test-case

Essentially, the config block throws an error, killing the tests. For some reason, however, no error is thrown when injecting the provider in the test using the module() method.

Any help or guidance here would be much appreciated. I am hoping I am simply missing something super obvious.

[caitp]

I was mistaken when I said that it should work already, config blocks and providers are added to the invoke queue in the order that they're called. This is a bug, in my opinion.

It should be easy to fix, although it might mean adding a separate invoke queue for config blocks in order to avoid breaking changes. Just waiting to hear if it's actually desirable or if the current behaviour should remain

For a workaround without the patch, since the order does matter, then yes, if you need to ensure that the config blocks are run after all providers are registered with DI, you should register the config blocks at the very end.

[caitp]

i still haven't heard whether or not it's desirable to let config blocks have a role in controlling the way providers are actually registered.

But I'm not totally convinced that they should play such a role, so yeah

[thebigredgeek]

Thanks @caitp Sorry about the fragmented questions I was moving from computer to laptop quite a bit and for some reason I kept missing messages.

[thebigredgeek]

you could just defer execution of config blocks by making them async (step n) (so that the entire context can resolve BEFORE the config blocks execute), but then you would also need to make the initial compile n + 1 (timeout AFTER injector, which should be fine since timeouts are FIFO).

[thebigredgeek]

also... how is module() in angular-mocks injecting providers? Because that implementation works fine. Are we not injecting providers by passing through to angular.module(...).config with angular-mocks? If we were, that behavior (the error case) should have been presented before I used a config block within the source code of the test case listed above.

[caitp]

@thebigredgeek angular.mock.module() doesn't use the loader api itself, however if you're saying beforeEach(module('myApp')), then your app's providers will be added to the injector. They would have been originally added via the loader api in your app. Anyways, doing it this way, there would be no problem running your config method because it would be added after the providers were already there.

[toota151]

7139

[toota151]

Goood