-
Notifications
You must be signed in to change notification settings - Fork 27.4k
feat(http): Please make buildUrl public #7429
Comments
Any progress on this? We need to do this again for some mocking API service. |
Personally I would be against just marking this one method as public. What I would do instead is to move it to a dedicated service responsible for serializing URLs and its params. Making this move would allow us to solve other issues - namely - difference in serilizing or array request params by different back-ends. I had a PR for this extract-logic-into-a-service for quite some time so maybe now is the time.... |
I would totally prefer a separate service which would be used by |
+1 for this feature. |
+1 |
@petebacondarwin I think that you've got super-powers to block users from a repo - @OMarohn is "spamming" all the threads in the AngularJS repo - presumably from an auto-responder... |
I see what powers I can muster |
@donaldpipowitch here is my proposal for solving this in 1.4: https://gist.github.com/pkozlowski-opensource/5a57d28ccfeacaba7661 your feedback would be much appreciated. |
+1 for pkozlowski's solution ... moving buildUrl into a $urlBuilder sevice seems like a good solution to me. Need this functionality |
Sounds good to me. +1 for a |
…ization Closes angular#7429 Closes angular#9224
…ization Closes angular#7429 Closes angular#9224
…ization Closes angular#7429 Closes angular#9224
…ization Closes angular#7429 Closes angular#9224
Closes angular#3740 Closes angular#7429 Closes angular#9224
Closes angular#3740 Closes angular#7429 Closes angular#9224
@donaldpipowitch @junhanamaki @ivanff Here you have another approach ready to be used in angular > v1.2 |
Closes angular#3740 Closes angular#7429 Closes angular#9224 Closes angular#11461
Feature Request:
It would be great if
buildUrl
would be public. It is a function which was copied nearly identical into Restangular and I had to do the same for a private module.The text was updated successfully, but these errors were encountered: