Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

number filter with fractionSize = 2 rounded 1.255 to 1.25 instead of 1.2.6 #7453

Closed
tan9 opened this issue May 14, 2014 · 2 comments
Closed

number filter with fractionSize = 2 rounded 1.255 to 1.25 instead of 1.2.6 #7453

tan9 opened this issue May 14, 2014 · 2 comments
Assignees
@lgalfaso
Labels
component: misc core frequency: low severity: inconvenient type: bug
Milestone
1.3.x - superlumi...

Comments

@tan9
Copy link

tan9 commented May 14, 2014

Test case here:
http://plnkr.co/edit/QN0aUyXDplngKRRLBM26?p=preview

1.2555 is ok
1.#55 where # is any number other than 2 is ok
fraction size other than 2 is ok
@lgalfaso lgalfaso self-assigned this May 15, 2014
@lgalfaso
Copy link
Contributor

It looks like a bug, the root reason is that when doing 1.255 * 100 the result is 125.4999999

lgalfaso added a commit to lgalfaso/angular.js that referenced this issue May 15, 2014
@lgalfaso
fix(numberFilter): fix rounding error edge case
dd27047 
Fix a number rounding error.

Closes angular#7453
@lgalfaso lgalfaso mentioned this issue May 15, 2014
Closed
@petebacondarwin petebacondarwin added this to the 1.3.0 milestone May 15, 2014
lgalfaso added a commit that referenced this issue May 15, 2014
@lgalfaso @petebacondarwin
fix(numberFilter): fix rounding error edge case
0388eed 
Fix a number rounding error.

Closes #7453
Closes #7478
@manodupont
Copy link

So, is it fixed actually. Not sure if I understand correctly all the "referencing" here ... ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@lgalfaso lgalfaso

Labels
component: misc core frequency: low severity: inconvenient type: bug
Projects
None yet
Milestone
1.3.x - superluminal-nudge
Development

Successfully merging a pull request may close this issue.

fix(numberFilter): fix rounding error edge case lgalfaso/angular.js
4 participants
@petebacondarwin @lgalfaso @tan9 @manodupont