stagger animation not working in minified script #7547
Comments
|
Just an FYI, both those links work in IE11. |
|
I was able to repro this on chrome. cc: @matsko |
|
Yeah it looks like only the first element is being animated. I'm checking it out. Thanks for finding this. |
|
Interestingly enough it breaks on the preview mode, but not inside of the edit mode. |
|
This may have something to do with the initial animation block that occurs upon bootstrap. But I still have no progress as to why the minified version isn't working. |
|
This is strange, I'm only able to see the bug on plunkr. Locally with the same code and using a minified build. I even tried referencing the application via localhost in plunkr and it works fine. My guess is that the animations are blocked upon bootstrap but since a minified file takes less time to download then somehow that effects when they're run? Although this wouldn't make sense locally. Does anyone have any other examples of this happening? |
|
I have made a similar observation (1.2.16); unfortunately I can only reproduce it on a Chromecast. |
|
Just testing real quickly with strict-di mode, it looks like there is some minification-unsafe code in ngAnimate, which could be related. |
|
Hmm, maybe not, actually |
|
Yeah, if it is related to code being minification unsafe, then we're probably missing a test--- and that's probably the thing which should be causing issues for minified code but not other code |
|
I'm still having a tough time reproducing this locally without plunkr using a minified script. Has anyone had any luck doing so? |
…mations When transition-delay and animation-delay were used to drive the staggering animation the result was unpredictable at times due to the browser not being able to register the generated delay styles in time. This caused a hard to track down bug that didn't have a solid solution when styles were being used. This fix ensures that stagger delays are handled by the $timeout service. Closes angular#7547 Closes angular#7228 BREAKING CHANGE If any stagger code consisted of having BOTH transition staggers and delay staggers together then that will not work the same way. Angular will no instead choose the highest stagger delay value and set the timeout to wait for that before applying the active CSS class.
…mations When transition-delay and animation-delay were used to drive the staggering animation the result was unpredictable at times due to the browser not being able to register the generated delay styles in time. This caused a hard to track down bug that didn't have a solid solution when styles were being used. This fix ensures that stagger delays are handled by the $timeout service. Closes angular#7547 Closes angular#7228 BREAKING CHANGE If any stagger code consisted of having BOTH transition staggers and delay staggers together then that will not work the same way. Angular will no instead choose the highest stagger delay value and set the timeout to wait for that before applying the active CSS class.
…mations When transition-delay and animation-delay were used to drive the staggering animation the result was unpredictable at times due to the browser not being able to register the generated delay styles in time. This caused a hard to track down bug that didn't have a solid solution when styles were being used. This fix ensures that stagger delays are handled by the $timeout service. Closes angular#7547 Closes angular#7228 BREAKING CHANGE If any stagger code consisted of having BOTH transition staggers and delay staggers together then that will not work the same way. Angular will no instead choose the highest stagger delay value and set the timeout to wait for that before applying the active CSS class.
…mations When transition-delay and animation-delay were used to drive the staggering animation the result was unpredictable at times due to the browser not being able to register the generated delay styles in time. This caused a hard to track down bug that didn't have a solid solution when styles were being used. This fix ensures that stagger delays are handled by the $timeout service. Closes angular#7547 Closes angular#7228 Closes angular#8547 BREAKING CHANGE If any stagger code consisted of having BOTH transition staggers and delay staggers together then that will not work the same way. Angular will no instead choose the highest stagger delay value and set the timeout to wait for that before applying the active CSS class.
…mations When transition-delay and animation-delay were used to drive the staggering animation the result was unpredictable at times due to the browser not being able to register the generated delay styles in time. This caused a hard to track down bug that didn't have a solid solution when styles were being used. This fix ensures that stagger delays are handled by the $timeout service. Closes angular#7228 Closes angular#7547 Closes angular#8297 Closes angular#8547 BREAKING CHANGE If any stagger code consisted of having BOTH transition staggers and delay staggers together then that will not work the same way. Angular will no instead choose the highest stagger delay value and set the timeout to wait for that before applying the active CSS class.
…mations When transition-delay and animation-delay were used to drive the staggering animation the result was unpredictable at times due to the browser not being able to register the generated delay styles in time. This caused a hard to track down bug that didn't have a solid solution when styles were being used. This fix ensures that stagger delays are handled by the $timeout service. Closes angular#7228 Closes angular#7547 Closes angular#8297 Closes angular#8547 BREAKING CHANGE If any stagger code consisted of having BOTH transition staggers and delay staggers together then that will not work the same way. Angular will no instead choose the highest stagger delay value and set the timeout to wait for that before applying the active CSS class.
…mations When transition-delay and animation-delay were used to drive the staggering animation the result was unpredictable at times due to the browser not being able to register the generated delay styles in time. This caused a hard to track down bug that didn't have a solid solution when styles were being used. This fix ensures that stagger delays are handled by the $timeout service. Closes angular#7228 Closes angular#7547 Closes angular#8297 Closes angular#8547 BREAKING CHANGE If any stagger code consisted of having BOTH transition staggers and delay staggers together then that will not work the same way. Angular will no instead choose the highest stagger delay value and set the timeout to wait for that before applying the active CSS class.
|
@matsko thanks, great work. |
…mations When transition-delay and animation-delay were used to drive the staggering animation the result was unpredictable at times due to the browser not being able to register the generated delay styles in time. This caused a hard to track down bug that didn't have a solid solution when styles were being used. This fix ensures that stagger delays are handled by the $timeout service. Closes angular#7228 Closes angular#7547 Closes angular#8297 Closes angular#8547 BREAKING CHANGE If any stagger code consisted of having BOTH transition staggers and delay staggers together then that will not work the same way. Angular will no instead choose the highest stagger delay value and set the timeout to wait for that before applying the active CSS class.
…mations When transition-delay and animation-delay were used to drive the staggering animation the result was unpredictable at times due to the browser not being able to register the generated delay styles in time. This caused a hard to track down bug that didn't have a solid solution when styles were being used. This fix ensures that stagger delays are handled by the $timeout service. Closes angular#7228 Closes angular#7547 Closes angular#8297 Closes angular#8547 BREAKING CHANGE If any stagger code consisted of having BOTH transition staggers and delay staggers together then that will not work the same way. Angular will now instead choose the highest stagger delay value and set the timeout to wait for that before applying the active CSS class.
|
The issue is repainting. Using Long story short, this should be fully working now. |
working example:
http://embed.plnkr.co/LTUm8soHhnodBwpCqbNa/preview
not working:
http://embed.plnkr.co/wL8iIF5K55R9gOY1pHVm/preview
the only difference is using minified version of angular-animation from google cdn. In not working example the enter animation is triggered only for first element and then all other are inserted immediately, without animation.
It seems this issue was fixed in 1.2.13 for non minified version but in minified version it is still present.
tested in chrome 34.0.1847.137 and firefox 29.0.1 with angular v1.2.16
The text was updated successfully, but these errors were encountered: