Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

i18n fr_ch and it_ch locales uses wrong decimal separator #7799

Closed
alexandrevoilab opened this issue Jun 12, 2014 · 8 comments
Closed

i18n fr_ch and it_ch locales uses wrong decimal separator #7799

alexandrevoilab opened this issue Jun 12, 2014 · 8 comments

Comments

@alexandrevoilab
Copy link

Hi,
Thoses two locales uses ',' as a decimal separator instead of '.' which is standard in Switzerland.
The locale de_ch uses the correct decimal separator.

Following the guidelines I've checked Closure's i18n scripts, and they are correct.
See fr_ch and it_ch

Thus, I'm submiting it here.

@caitp
Copy link
Contributor

caitp commented Jun 12, 2014

Currently, only the "common locales" number formats are being processed. See https://github.com/angular/angular.js/tree/master/i18n/closure.

Working on generating locale info directly from CLDR, without closure, so this may change soon (but it takes much longer when processing the full range of locales rather than just the common ones!). In the mean time, you're free to send a pull request to get us using the "extra" locales for number formats, too.

@alexandrevoilab
Copy link
Author

I've made the changes. But can't push since my CLA is not accepted yet. At least I think this is why my push are rejected.

I will create a pull request ASAP.

@caitp
Copy link
Contributor

caitp commented Jun 12, 2014

@alexandrevoilab you can send a pull request whether you've signed the CLA or not =)

@alexandrevoilab
Copy link
Author

My bad, I was trying to push on the master repo...

@alexandrevoilab
Copy link
Author

Up?

@IgorMinar IgorMinar added this to the 1.3.0 milestone Jul 25, 2014
mgallag pushed a commit to mgallag/angular.js that referenced this issue Sep 10, 2014

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Fixes number formatting and symbols for many locales.
Adds support for additional locales.

Closes angular#8931
Closes angular#8583
Closees angular#7799
mgallag pushed a commit to mgallag/angular.js that referenced this issue Sep 10, 2014

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Fixes number formatting and symbols for many locales.
Adds support for additional locales.

Closes angular#8931
Closes angular#8583
Closes angular#7799
mgallag added a commit to mgallag/angular.js that referenced this issue Sep 10, 2014

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Fixes number formatting and symbols for many locales.
Adds support for additional locales.

Closes angular#8931
Closes angular#8583
Closes angular#7799
@caitp caitp closed this as completed in 6a96a82 Sep 11, 2014
@srl295
Copy link

srl295 commented Sep 16, 2014

@caitp hi, saw that you did a regenerate (sounds like from closure data) - please note CLDR 26 (edit: has just finished) final beta please check latest CLDR data as well and provide feedback. http://unicode.org/pipermail/unicode/2014-September/000935.html

@caitp
Copy link
Contributor

caitp commented Sep 16, 2014

@srl295 we don't generate locale data directly from CLDR currently, we piggyback on the CLDR processing done by https://github.com/google/closure-library/ --- I would suggest bringing it up there

@srl295
Copy link

srl295 commented Sep 16, 2014

@caitp OK. I saw your note earlier about wanting to generate directly from CLDR, which is why I mentioned something. update Closure says it's on CLDR 25, so latest GA data.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants