filter test typos and another test case

[rolfyone]

There was a test submission earlier regarding filtering on empty text.

While investigating, there were a couple of typos I found, and I added a test case showing the described issue, and how to solve the problem of filtering on an empty string.

I'm not sure how to submit it, whether to push my tested change etc, so I figured I'd raise it as an issue, and if someone wants to push the commit themselves I dont mind... I tried to find things in 'getting started', but couldnt really find any newbie dev guidelines that covered this kind of thing.... no doubt I missed a huge section of doco somewhere...

anyway a diff is

diff --git a/test/ng/filter/filterSpec.js b/test/ng/filter/filterSpec.js
index fecfcf7..8398949 100644
--- a/test/ng/filter/filterSpec.js
+++ b/test/ng/filter/filterSpec.js
@@ -49,7 +49,7 @@ describe('Filter: filter', function() {
     expect(filter(items, function(i) {return i.done;}).length).toBe(1);
   });

-  it('should take object as perdicate', function() {
+  it('should take object as predicate', function() {
     var items = [{first: 'misko', last: 'hevery'},
                  {first: 'adam', last: 'abrons'}];

@@ -61,7 +61,7 @@ describe('Filter: filter', function() {
   });


-  it('should support predicat object with dots in the name', function() {
+  it('should support predicate object with dots in the name', function() {
     var items = [{'first.name': 'misko', 'last.name': 'hevery'},
                  {'first.name': 'adam', 'last.name': 'abrons'}];

@@ -81,6 +81,16 @@ describe('Filter: filter', function() {
     ]);
   });

+  it('should be able to use exact match to match empty strings', function() {
+    var items = [{person: {name: 'John'}},
+                 {person: {name: 'Rita'}},
+                 {person: {name: 'Billy'}},
+                 {person: {name: ''}},
+                 {person: {name: 'Joan'}}];
+    expect(filter(items, {person: {name: ''}}).length).toBe(5);
+    expect(filter(items, {person: {name: ''}}, true).length).toBe(1);
+  });
+

   it('should match any properties for given "$" property', function() {
     var items = [{first: 'tom', last: 'hevery'},

[Narretz]

Hi, thanks for the patch. If you want to give it a go, in https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#submitting-a-pull-request there's a pretty good overview of how to submit a pull request.

[rolfyone]

ok cool - i'll give it a go after work :)

[rolfyone]

just so i remember, the initial issue was #7890

[rolfyone]

still not able to do a git push :|

[caitp]

Hey, so part of the first commit has been merged, but the issue with the test added is that it's really testing something which is already being tested (the behaviour of the objectEquality flag).

So, we've opted to just remove the extra test, because the test serves as a sort of inaccurate way of documenting what that flag actually does. It's perfectly acceptable to use it in this way, but it's quite possible for it to actually not do what you really want under certain circumstances, so I prefer to keep that out.

However, google will serve this issue to people who find it, so if they're having trouble with that particular issue and need a quick fix for it, this should definitely help them find it.

Thanks @rolfyone !

[rolfyone]

no problems - thanks for your help :)

On Thu, Jul 17, 2014 at 7:08 AM, Caitlin Potter notifications@github.com
wrote:

Hey, so part of the first commit has been merged, but the issue with the
test added is that it's really testing something which is already being
tested (the behaviour of the objectEquality flag).

So, we've opted to just remove the extra test, because the test serves as
a sort of inaccurate way of documenting what that flag actually does. It's
perfectly acceptable to use it in this way, but it's quite possible for it
to actually not do what you really want under certain circumstances, so I
prefer to keep that out.

However, google will serve this issue to people who find it, so if they're
having trouble with that particular issue and need a quick fix for it, this
should definitely help them find it.

Thanks @rolfyone https://github.com/rolfyone !

—
Reply to this email directly or view it on GitHub
#7891 (comment).