-
Notifications
You must be signed in to change notification settings - Fork 27.4k
Number field validation broken #7936
Comments
Try type "9.9999999999999999e+23" or type "99999999999999999999999999999999999999999999" and press the up button, and you will see. |
I think it should validate as NOT number also NOT Numbers .... ex "abc" |
you're right, obviously --- I think this is a regression though, either in Chromium or in angular --- because this was definitely working at the time this was checked in |
I'm looking into it |
Yeah I think I can write a fix for this quickly, I really, REALLY wish Ian had plotted the constraint validation api better :( |
Thank you much Caitlin. |
I'll see if that changes fixes the docs page once it builds on the CI server, I think it should |
http://ci.angularjs.org/job/angular.js-caitlin/393/artifact/build/docs/api/ng/input/input%5Bnumber%5D (yes it will still incorrectly report 'required' error --- that is going to take a bit more work to fix, and that's been planned for a while) |
This CL improves mocking support for HTML5 validation, and ensures that it works correctly along with debounced commission of view values. Closes angular#7936 Closes angular#7937
Steps to reproduce: just try to fill non number chars in example at https://docs.angularjs.org/api/ng/input/input%5Bnumber%5D
and check validation result. In myForm.input.$error collection the "number" property is always false.
The text was updated successfully, but these errors were encountered: