Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

ng-animate-children does not always work with class-based animations #8092

Closed
Narretz opened this issue Jul 7, 2014 · 3 comments
Closed

ng-animate-children does not always work with class-based animations #8092

Narretz opened this issue Jul 7, 2014 · 3 comments
Assignees
@matsko
Labels
component: ngAnimate
Milestone
1.3.0-rc.5

Comments

@Narretz
Copy link
Contributor

Narretz commented Jul 7, 2014

I played around with ng-animate-children and I think I found a few bugs.

a) when I use ng-class inside ng-if, the child animation is not called when the element leaves
b) when I use $animate.enter / leave on the parent element, a child element with ng-class does not get animated at all, and when you execute enter while leave still runs, enter does not work. (click the move animation button quickly while executes leave). Sometimes also ng-animate and slide-add classes get stuck on the element.

Both animations use the save $scope variable.

I set up a plunker here:
http://plnkr.co/edit/tpl:FrTqqTNoY8BEfHs9bB0f?p=preview
http://plnkr.co/edit/CE4nEBU1e2jIhwUmUzdK?p=preview

I also tested case b) with $animate.addClass instead of ng-class, which also didn't work Ideally this should also work.

@matsko Can you please have a look? Thanks!
@Narretz Narretz added this to the 1.3.0 milestone Jul 7, 2014
@matsko matsko self-assigned this Jul 7, 2014
@matsko
Copy link
Contributor

matsko commented Jul 17, 2014

These are all clear examples. Is the plunkr link not properly working? I can try to setup a few examples if you don't have them already.

@Narretz
Copy link
Contributor Author

Narretz commented Jul 22, 2014

Sorry, I had the wrong plnkr link. Now it should work: http://plnkr.co/edit/CE4nEBU1e2jIhwUmUzdK?p=preview The two buttons correspond to a) and b)

@btford btford removed the gh: issue label Aug 20, 2014
@jeffbcross jeffbcross modified the milestones: 1.3.0-rc.5, 1.3.0 Sep 29, 2014
matsko added a commit to matsko/angular.js that referenced this issue Oct 8, 2014
@matsko
fix($animate): permit class-based animations for leave operations if …
b52f9df 
…ngAnimateChildren is enabled

Prior to this fix, $animate.leave placed a disabled animation on the element
which prevented ngAnimateChildren from properly working. This patch now
addresses that issue.

Closes angular#8092
@matsko matsko mentioned this issue Oct 8, 2014
Closed
matsko added a commit to matsko/angular.js that referenced this issue Oct 8, 2014
@matsko
fix($animate): permit class-based animations for leave operations if …
67ce449 
…ngAnimateChildren is enabled

Prior to this fix, $animate.leave placed a disabled animation on the element
which prevented ngAnimateChildren from properly working. This patch now
addresses that issue.

Closes angular#8092
@matsko
Copy link
Contributor

matsko commented Oct 8, 2014

This is now fixed in #9491

@matsko matsko closed this as completed in df1a00b Oct 8, 2014
bullgare pushed a commit to bullgare/angular.js that referenced this issue Oct 9, 2014
@matsko @bullgare
fix($animate): permit class-based animations for leave operations if …
b79d080 
…ngAnimateChildren is enabled

Prior to this fix, $animate.leave placed a disabled animation on the element
which prevented ngAnimateChildren from properly working. This patch now
addresses that issue.

Closes angular#8092
Closes angular#9491
@hamfastgamgee hamfastgamgee mentioned this issue Nov 24, 2014
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@matsko matsko

Labels
component: ngAnimate
Projects
None yet
Milestone
1.3.0-rc.5
4 participants
@matsko @jeffbcross @btford @Narretz