Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs(ngModel): document that objects passed to $setViewValue should be copied #8095

Closed
petebacondarwin opened this issue Jul 7, 2014 · 1 comment
Closed

docs(ngModel): document that objects passed to $setViewValue should be copied #8095

petebacondarwin opened this issue Jul 7, 2014 · 1 comment
Labels
needs: work PRs plz! type: docs
Milestone
1.3.0-beta.15

Comments

@petebacondarwin
Copy link
Contributor

ngModel doesn't watch $viewValue objects deeply and also does not make copies of those objects. This means that changes to the properties of those objects does not trigger ngModel changes.

So if your input directive provides objects (e.g. Date objects) to $setViewValue then it should make a copy before sending it into $setViewValue.

See #7965
@petebacondarwin petebacondarwin added this to the 1.3.0-beta.15 milestone Jul 7, 2014
@petebacondarwin
Copy link
Contributor Author

@shahata - fancy knocking this up?

@shahata shahata mentioned this issue Jul 8, 2014
Closed
ckknight pushed a commit to ckknight/angular.js that referenced this issue Jul 16, 2014
@shahata
docs(ngModel): objects passed to $setViewValue should be copied
120f88e 
Closes angular#8095
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
needs: work PRs plz! type: docs
Projects
None yet
Milestone
1.3.0-beta.15
Development

Successfully merging a pull request may close this issue.

docs(ngModel): objects passed to $setViewValue should be copied
1 participant
@petebacondarwin