Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

angular.equals needs to test for double $ #8325

Open
joshbowdoin opened this issue Jul 24, 2014 · 2 comments
Open

angular.equals needs to test for double $ #8325

joshbowdoin opened this issue Jul 24, 2014 · 2 comments
Labels
frequency: low severity: confusing type: bug
Milestone
Backlog - won't fix

Comments

@joshbowdoin
Copy link
Contributor

Due to #6253, angular.equals needs to test for key.charAt(0) === '$' && key.charAt(1) === '$', not simply key.charAt(0) === '$'

The current test for single '$' breaks angular.equals, as well as anything that relies on it ($watch, for example).
@btford
Copy link
Contributor

btford commented Jul 24, 2014

Can you please provide a reproduction via jsbin, plnkr.co or jsfiddle that shows how this change concretely affects you?

@btford btford added this to the Backlog milestone Jul 24, 2014
@joshbowdoin
Copy link
Contributor Author

Use case - where checking a model for changes before persisting to server:
http://plnkr.co/edit/SVd3xVhhtFZ6XdOnaS8z?p=preview

@joshbowdoin joshbowdoin mentioned this issue Aug 1, 2014
Closed
This was referenced Aug 1, 2014
Closed
Closed
@btford btford removed the gh: issue label Aug 20, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
frequency: low severity: confusing type: bug
Projects
None yet
Milestone
Backlog - won't fix
Development

No branches or pull requests
2 participants
@btford @joshbowdoin