cleanData override breaks when jQuery UI is included after angular

[andyperlitch]

@attilah sums this issue up very well in his gist, but here's the TLDR:

angular overrides jQuery.cleanData function, storing original in jQuery.cleanData.$$original. jQuery UI also overrides this method. So if you incidentally include jquery, then angular, then jquery UI (not farfetched, grunt bower-install does not guarantee a particular order), the $$original is no longer available and angular throws a undefined is not a function error when trying to call $$original.

[mgol]

The property is used because the bindJQuery function may be invoked twice and the $$original check is meant to prevent double wrapping. Since my recent commit upgrading to jQuery 2.1 (9e7cb3c) we also use .$$original in the $compile service.

We'll probably have to export it directly to the angular object as you proposed. I'll look into it.

Thanks for the report!

[andyperlitch]

no problem! thanks!

[mgol]

(thinking out loud)

I think that putting all other cleanData patches before the Angular's one will be required as we need to invoke the cleanData method in:

angular.js/src/ng/compile.js

Line 2050 in 60c13a1

jQuery.cleanData.$$original([firstElementToRemove]);

and we need to invoke it without the Angular patch but with all other patches so that we don't break other libs. But if we wrapped first and jQuery UI wrapped second, we can't invoke the version patched only by jQuery UI since there's no such version available.

One way would be to extend the method with an optional additional parameter-flag indicating the Angular patch should be skipped but unfortunately jQuery UI invokes the patched method explicitely passing only the first parameter:
https://github.com/jquery/jquery-ui/blob/f7429edfe96d322cdec850f7207efba8125767a6/ui/widget.js#L26-L43
so the other one would be lost.

EDIT: or maybe I'll try to use a flag from outside the cleanData itself. Work in progress...

[mgol]

Fix landed.

[andyperlitch]

Nice! Fantastic work, thanks a lot!