Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Linky on emails breaks with double quote in 1.2.21 #8520

Closed
cebjyre opened this issue Aug 7, 2014 · 3 comments
Closed

Linky on emails breaks with double quote in 1.2.21 #8520

cebjyre opened this issue Aug 7, 2014 · 3 comments

Comments

@cebjyre
Copy link

cebjyre commented Aug 7, 2014

There's a problem introduced in 1.2.21 that results in linky falling over when it hits an email address inside a double quoted string:
see http://plnkr.co/edit/IMUbLbrOpkYVq4l5i3hQ?p=preview for the correct(ish - I'd prefer if the trailing quote wasn't included in the linked version) behaviour in 1.2.20, and then have a look at the previous version of the plunk to see the code being bad in 1.2.21

@btford
Copy link
Contributor

btford commented Aug 20, 2014

A fix landed in a9d2271 and should be in the next 1.3 and 1.2 releases.

@cebjyre
Copy link
Author

cebjyre commented Aug 21, 2014

Awesome, thanks.

@lorenzhs
Copy link

Actually, this didn't only affect emails, but also URLs. Thanks for fixing it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants