Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

order of animation staggering #8547

Closed
fxck opened this issue Aug 9, 2014 · 1 comment
Closed

order of animation staggering #8547

fxck opened this issue Aug 9, 2014 · 1 comment

Comments

@fxck
Copy link

fxck commented Aug 9, 2014

http://plnkr.co/edit/sceDXtz9qwJKpuBHhn9T?p=preview

It looks like setting delay on .ng-enter causes order of stagger to be wrong(the first item is animated last)

Why I need the initial delay in the first place? I'm using ng-animate-children, but the animation on parent takes say 500ms, so I need to delay animation of the children by those 500ms..

Even if it worked, it wouldn't really be ideal, since I only need that delay in when the parent is animating, but that's another story..

related #7105 cc @matsko

@matsko
Copy link
Contributor

matsko commented Aug 16, 2014

matsko added a commit to matsko/angular.js that referenced this issue Aug 16, 2014
…mations

When transition-delay and animation-delay were used to drive the staggering
animation the result was unpredictable at times due to the browser not being
able to register the generated delay styles in time. This caused a hard to
track down bug that didn't have a solid solution when styles were being used.

This fix ensures that stagger delays are handled by the $timeout service.

Closes angular#7547
Closes angular#7228
Closes angular#8547

BREAKING CHANGE

If any stagger code consisted of having BOTH transition staggers and delay staggers
together then that will not work the same way. Angular will no instead choose
the highest stagger delay value and set the timeout to wait for that before
applying the active CSS class.
@matsko matsko added this to the 1.3.0-beta.19 milestone Aug 16, 2014
matsko added a commit to matsko/angular.js that referenced this issue Aug 16, 2014

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…mations

When transition-delay and animation-delay were used to drive the staggering
animation the result was unpredictable at times due to the browser not being
able to register the generated delay styles in time. This caused a hard to
track down bug that didn't have a solid solution when styles were being used.

This fix ensures that stagger delays are handled by the $timeout service.

Closes angular#7228
Closes angular#7547
Closes angular#8297
Closes angular#8547

BREAKING CHANGE

If any stagger code consisted of having BOTH transition staggers and delay staggers
together then that will not work the same way. Angular will no instead choose
the highest stagger delay value and set the timeout to wait for that before
applying the active CSS class.
matsko added a commit to matsko/angular.js that referenced this issue Aug 16, 2014
…mations

When transition-delay and animation-delay were used to drive the staggering
animation the result was unpredictable at times due to the browser not being
able to register the generated delay styles in time. This caused a hard to
track down bug that didn't have a solid solution when styles were being used.

This fix ensures that stagger delays are handled by the $timeout service.

Closes angular#7228
Closes angular#7547
Closes angular#8297
Closes angular#8547

BREAKING CHANGE

If any stagger code consisted of having BOTH transition staggers and delay staggers
together then that will not work the same way. Angular will no instead choose
the highest stagger delay value and set the timeout to wait for that before
applying the active CSS class.
matsko added a commit to matsko/angular.js that referenced this issue Aug 19, 2014
…mations

When transition-delay and animation-delay were used to drive the staggering
animation the result was unpredictable at times due to the browser not being
able to register the generated delay styles in time. This caused a hard to
track down bug that didn't have a solid solution when styles were being used.

This fix ensures that stagger delays are handled by the $timeout service.

Closes angular#7228
Closes angular#7547
Closes angular#8297
Closes angular#8547

BREAKING CHANGE

If any stagger code consisted of having BOTH transition staggers and delay staggers
together then that will not work the same way. Angular will no instead choose
the highest stagger delay value and set the timeout to wait for that before
applying the active CSS class.
@btford btford modified the milestones: 1.3.0-beta.19, 1.3.0-beta.20 Aug 22, 2014
matsko added a commit to matsko/angular.js that referenced this issue Aug 25, 2014
…mations

When transition-delay and animation-delay were used to drive the staggering
animation the result was unpredictable at times due to the browser not being
able to register the generated delay styles in time. This caused a hard to
track down bug that didn't have a solid solution when styles were being used.

This fix ensures that stagger delays are handled by the $timeout service.

Closes angular#7228
Closes angular#7547
Closes angular#8297
Closes angular#8547

BREAKING CHANGE

If any stagger code consisted of having BOTH transition staggers and delay staggers
together then that will not work the same way. Angular will no instead choose
the highest stagger delay value and set the timeout to wait for that before
applying the active CSS class.
matsko added a commit to matsko/angular.js that referenced this issue Aug 26, 2014
…mations

When transition-delay and animation-delay were used to drive the staggering
animation the result was unpredictable at times due to the browser not being
able to register the generated delay styles in time. This caused a hard to
track down bug that didn't have a solid solution when styles were being used.

This fix ensures that stagger delays are handled by the $timeout service.

Closes angular#7228
Closes angular#7547
Closes angular#8297
Closes angular#8547

BREAKING CHANGE

If any stagger code consisted of having BOTH transition staggers and delay staggers
together then that will not work the same way. Angular will now instead choose
the highest stagger delay value and set the timeout to wait for that before
applying the active CSS class.
@matsko matsko closed this as completed in 23da614 Aug 26, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants