Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Two-way binding doesn't work if initial value is NaN #8553

Closed
gabrielmaldi opened this issue Aug 10, 2014 · 1 comment
Closed

Two-way binding doesn't work if initial value is NaN #8553

gabrielmaldi opened this issue Aug 10, 2014 · 1 comment

Comments

@gabrielmaldi
Copy link
Contributor

If the initial value of a scope property with two-way binding is NaN, subsequent updates will have no effect:

http://jsfiddle.net/gabrielmaldi/yxkaf271

Angular version: v1.3.0-build.3034+sha.e4e7e94

Tested on:

  • Chrome 36 (Mac)
  • Safari 7 (Mac)
@gabrielmaldi gabrielmaldi changed the title Two-way binding doesn't work if initial value is NaN Two-way binding doesn't work if initial value is NaN Aug 10, 2014
@caitp
Copy link
Contributor

caitp commented Aug 10, 2014

This is valid, will be patched.

@caitp caitp mentioned this issue Aug 10, 2014
Closed
@caitp caitp closed this as completed in 5038bf7 Aug 10, 2014
caitp added a commit to caitp/angular.js that referenced this issue Aug 10, 2014
@caitp
fix($compile): make '='-bindings NaN-aware
18113e5 
Update parent and child scopes correctly when a '='-binding changes from a NaN value.

TBR by angular-core

Closes angular#8553
Closes angular#8554

Conflicts:
	test/ng/compileSpec.js
caitp added a commit that referenced this issue Aug 10, 2014
@caitp
fix($compile): make '='-bindings NaN-aware
0b0acb0 
Update parent and child scopes correctly when a '='-binding changes from a NaN value.

TBR by angular-core

Closes #8553
Closes #8554

Conflicts:
	test/ng/compileSpec.js
@theurere theurere mentioned this issue Aug 26, 2014
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix($compile): make '='-bindings NaN-aware caitp/angular.js
2 participants
@caitp @gabrielmaldi