ngSwitch removes DOM elements twice

[matsko]

The code up here:
https://github.com/angular/angular.js/blob/master/src/ng/directive/ngSwitch.js#L150

May seem to contain elements that are called here:
https://github.com/angular/angular.js/blob/master/src/ng/directive/ngSwitch.js#L159

The issue may relate to transclusion blocks that were added in:
ac37915

[btford]

@matsko is this a regression?

[IgorMinar]

not a regression, but a perf issue.

functionality is not affected, we just do work unnecessarily as far as I can tell.

[thebigredgeek]

Like this? #8833

[caitp]

The referenced sha specifically fixes an issue where DOM nodes were attempted to be removed twice (resulting in a type error), but it's quite likely that there are more problems with it

[thebigredgeek]

Part of the problem is that the callback for the $animate.leave will always reference the last value of i in that loop. There is a closure issue there.

[IgorMinar]

I just spoke with @matsko about this one. there is one test that fails if the direct removal is removed (:)).

we think the test is no longer valid or was never valid and @matsko is going to handle that.

[IgorMinar]

I don't think we need the callback at all

[thebigredgeek]

Hmmm, so we should keep the complete drain but remove the selected callback drain for $animate.leave

[thebigredgeek]

Also, just this morning getting this when I try to package :(

Running "minall" task

Exception in thread "main" java.lang.UnsupportedClassVersionError: com/google/javascript/jscomp/CommandLineRunner : Unsupported major.minor version 51.0
at java.lang.ClassLoader.defineClass1(Native Method)
at java.lang.ClassLoader.defineClassCond(ClassLoader.java:637)
at java.lang.ClassLoader.defineClass(ClassLoader.java:621)
at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:141)
at java.net.URLClassLoader.defineClass(URLClassLoader.java:283)
at java.net.URLClassLoader.access$000(URLClassLoader.java:58)
at java.net.URLClassLoader$1.run(URLClassLoader.java:197)
at java.security.AccessController.doPrivileged(Native Method)
at java.net.URLClassLoader.findClass(URLClassLoader.java:190)
at java.lang.ClassLoader.loadClass(ClassLoader.java:306)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:301)
at java.lang.ClassLoader.loadClass(ClassLoader.java:247)
at java.lang.ClassLoader.defineClass1(Native Method)
at java.lang.ClassLoader.defineClassCond(ClassLoader.java:637)
at java.lang.ClassLoader.defineClass(ClassLoader.java:621)
at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:141)
at java.net.URLClassLoader.defineClass(URLClassLoader.java:283)
at java.net.URLClassLoader.access$000(URLClassLoader.java:58)
at java.net.URLClassLoader$1.run(URLClassLoader.java:197)
at java.security.AccessController.doPrivileged(Native Method)
at java.net.URLClassLoader.findClass(URLClassLoader.java:190)
at java.lang.ClassLoader.loadClass(ClassLoader.java:306)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:301)
at java.lang.ClassLoader.loadClass(ClassLoader.java:247)

[IgorMinar]

you need java7

[thebigredgeek]

Oh okay yes I see ;)

[matsko]

@thebigredgeek this was fixed using $animate.cancel.

[matsko]

c9b0bfe