This repository was archived by the owner on Apr 12, 2024. It is now read-only.
  
  
  
  
fix($compile): use the correct namespace for transcluded svg elements #8716
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Via transclusion, svg elements can occur outside an
<svg>container in anAngular template but are put into an
<svg>container through compilationand linking.
E.g.
Given that
svg-containeris a transcluding directive withthe followingg template:
The following markup creates a
<circle>inside of an<svg>elementduring runtime:
However, this produces non working
<circle>elements, as svg elementsneeds to be created inside of an
<svg>element.This change detects for most cases the correct namespace of transcluded content
and recreates that content in the correct
<svg>containerwhen needed during compilation. For special cases it adds an addition argument
to
$transcludethat allows to specify the future parent node of elementsthat will be cloned and attached using the
cloneAttachFn.Related to #8494