-
Notifications
You must be signed in to change notification settings - Fork 27.4k
Conversation
I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS. Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match. If you signed the CLA as a corporation, please let us know the company's name. Thanks a bunch! PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR. |
here is a simplified version: https://github.com/IgorMinar/angular.js/compare/svg-transclusion that version doesn't require passing the namespace info throughout the whole compiler but has a downside that nested transclusion during which we jump between SVG and HTML namespaces doesn't work - this means that the "should handle custom svg containers that transclude to foreignObject that transclude html" test is failing. |
Boo! I had that one passing. :P Haha. So I assume the problem is that when it goes to compile the transclusion On Tue, Aug 19, 2014 at 11:35 PM, Igor Minar notifications@github.com
Ben Lesh |
closing this one in favor of #8716 which landed today thanks for all the help Ben and please test the beta.19 that is going out right now! |
This is in relation to #8494
Things to note:
Basic Idea
Added namespace tracking to the compile process.
When a namespace change is detected, it updates a namespace context object that contains methods to wrap and clone elements appropriately. There is some ugliness where the namespace context had to be ferried around via some monkey-patches to get them into the appropriate closures.