-
Notifications
You must be signed in to change notification settings - Fork 27.4k
fix($http): propagate status -1 for aborted requests #8756
fix($http): propagate status -1 for aborted requests #8756
Conversation
fc8bc38
to
7b3d8b6
Compare
02dc2aa
to
fd2d6c0
Compare
cad9560
to
f294244
Compare
e8dc429
to
e83fab9
Compare
4dd5a20
to
998c61c
Compare
Can I help with something to make this PR move forward? |
LGTM |
Why this feature was introduced as patch for Angular 1.3.x? I think it is a breaking change and should be introduced in Angular 1.4.x. because many developers use 0 instead of -1. proof. |
@dizel3d - thanks for getting in touch. The status of an error was not defined as a public API in the Angular docs. The reason we used to (incorrectly) return 0 for all errors was that browsers were inconsistent in their error return values. |
Fixes #4491