This repository was archived by the owner on Apr 12, 2024. It is now read-only.
feat($http): flag timed out requests #11272
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the response object passed into the then method will have an additional timedOut=true property when the request was aborted due to a timeout.
| // normalize internal statuses to 0 | ||
| status = Math.max(status, 0); | ||
|
|
||
| (isSuccess(status) ? deferred.resolve : deferred.reject)({ | ||
| var result = { | ||
| data: response, | ||
| status: status, | ||
| headers: headersGetter(headers), | ||
| config: config, | ||
| statusText: statusText |
There was a problem hiding this comment.
why not just add timeOut: timeOut here?
There was a problem hiding this comment.
I didn't want to alter the current success result, since it logically can never be a timeout (hence timeOut: false would be redundant; I think of timeOut as a possible outcome of an error result). But maybe it'd better to add timeOut: [true | false] every time.
Another question: would you go with timedOut, timeOut, or timeout?
|
this looks interesting, but it needs some tests and documentation. |
|
I gave it a bit of thought and think that the status approach is better. So I'll wait for #8756 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows differentiating a network error from a timeout.
If you guys thinks this is OK I'll write some tests and update the docs.