maxlength directive doesn't work with numbers

[hon2a]

The maxlength directive is broken when used with Number model values in the current Beta. When I try using timepicker from angular-bootstrap, the hours/minutes inputs become invalid as soon as they reach values >= 10. This happens because, for the sake of readability, values < 10 are prefixed with a zero and saved to the model as strings. Values >= 10 are saved as numbers, which makes this offending line in the directive:

return ctrl.$isEmpty(value) || value.length <= maxlength;

fail, as value.length equals to undefined for Numbers. Changing the code to

return ctrl.$isEmpty(value) || String(value).length <= maxlength;

seems to work just fine.

---

Thanks in advance for the fix.

[Narretz]

This is a duplicate of #7848

[Narretz]

I'll try to get someone interested in this for the next beta / RC.

[caitp]

a fix for this has already been written, it's never been reviewed or merged #7968

[Narretz]

The PR in question is #7968
I pushed it to the next RC.